From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19814-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 15204 invoked by alias); 5 Nov 2002 22:17:11 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15160 invoked from network); 5 Nov 2002 22:17:11 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 5 Nov 2002 22:17:11 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gA5Lscw28104
	for <gdb-patches@sources.redhat.com>; Tue, 5 Nov 2002 16:54:38 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA5MH1l23778;
	Tue, 5 Nov 2002 17:17:02 -0500
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id gA5MGtD17001;
	Tue, 5 Nov 2002 14:16:55 -0800
Message-ID: <3DC84357.95223AD3@redhat.com>
Date: Tue, 05 Nov 2002 14:17:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: David Carlton <carlton@math.stanford.edu>
CC: gdb-patches@sources.redhat.com, Fernando Nasser <fnasser@redhat.com>,
   cagney <cagney@redhat.com>
Subject: Re: [rfa/testsuite] Don't display values in output of pc-fp.exp
References: <ro1u1ivacl5.fsf@jackfruit.Stanford.EDU>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-11/txt/msg00070.txt.bz2

David Carlton wrote:
> 
> The tests in pc-fp.exp display the actual values of $pc and $fp in
> their PASS messages.  That makes regression testing a bit more
> annoying for me: the value of $fp changes with every change I make to
> GDB.  Is it okay to tweak the PASS messages not to display those
> values?
> 
> David Carlton

I'm not the maintainer, but the suggestion seems sound.

> carlton@math.stanford.edu
> 
> 2002-11-05  David Carlton  <carlton@math.stanford.edu>
> 
>         * gdb.base/pc-fp.exp (get_valueofx): Don't display 'val' in PASS
>         message.
> 
> Index: pc-fp.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
> retrieving revision 1.1
> diff -u -p -r1.1 pc-fp.exp
> --- pc-fp.exp   25 Sep 2002 20:30:38 -0000      1.1
> +++ pc-fp.exp   5 Nov 2002 22:09:51 -0000
> @@ -62,7 +62,7 @@ proc get_valueofx { fmt exp default } {
>      gdb_expect {
>         -re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
>             set val $expect_out(1,string)
> -           pass "get value of ${exp} ($val)"
> +           pass "get value of ${exp}"
>         }
>         timeout {
>             set size ${default}