Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@math.stanford.edu>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com,
	Fernando Nasser <fnasser@redhat.com>, cagney <cagney@redhat.com>
Subject: Re: [rfa/testsuite] Don't display values in output of pc-fp.exp
Date: Tue, 05 Nov 2002 15:11:00 -0000	[thread overview]
Message-ID: <ro1pttja9yj.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <3DC84C23.8070801@redhat.com>

On Tue, 05 Nov 2002 17:54:27 -0500, Andrew Cagney <ac131313@redhat.com> said:

>> The tests in pc-fp.exp display the actual values of $pc and $fp in
>> their PASS messages.  That makes regression testing a bit more
>> annoying for me: the value of $fp changes with every change I make
>> to GDB.  Is it okay to tweak the PASS messages not to display those
>> values?

> As far as I know, anything in trailing paren should be ignored when
> comparing test results.  You might want to tweak your script (I've
> attached mine) to do this.

Wow: your script is complicated.  I just do

  diff -u (first file) (second file) | grep -v schedlock

I could do something more complicated than that, of course; on the
other hand, I'm still not convinced that I should.  It seems to me
that details like the value of the variables in question shouldn't be
in gdb.sum: if I want that level of information, I'll look in gdb.log.
I think there's a virtue in having gdb.sum in a format that's easily
checkable without worrying about parsing issues: the easier it is to
do regression testing, the more often it will happen.

> Also, why is FP/PC changing?  Your GDB changes shouldn't affect the
> behavior of the target program's $fp / $pc.

That's a good point; I hadn't thought of that.  I'm actually not
entirely sure what it is that leads to the value of $fp changing from
test run to test run.  But I will make the empirical observation that
it does change from test run to test run, and I'd be shocked if those
changes reflected introduction of new bugs into GDB.

David Carlton
carlton@math.stanford.edu


  reply	other threads:[~2002-11-05 23:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-05 14:14 David Carlton
2002-11-05 14:17 ` Michael Snyder
2002-11-05 14:54 ` Andrew Cagney
2002-11-05 15:11   ` David Carlton [this message]
2002-11-05 15:20     ` Andrew Cagney
2002-11-05 15:41     ` Andrew Cagney
     [not found]     ` <3DC98B56.2861A478@redhat.com>
2002-11-06 14:57       ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ro1pttja9yj.fsf@jackfruit.Stanford.EDU \
    --to=carlton@math.stanford.edu \
    --cc=ac131313@redhat.com \
    --cc=cagney@redhat.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox