* [PATCH] Re-order includes in defs.h
@ 2002-09-27 14:34 Mark Kettenis
2002-09-27 14:57 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2002-09-27 14:34 UTC (permalink / raw)
To: gdb-patches
This re-orders the includes on defs.h a bit to avoid problems with
PARAMS getting multiply defined.
Checked in on the trunk. If this doesn't lead to any problems, I'll probably move it over to the branch.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* defs.h: Move inclusion of "ansidecl.h" before "gdb_locale.h".
Fix some whitespace problems.
Index: defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.97
diff -u -p -r1.97 defs.h
--- defs.h 19 Sep 2002 03:58:41 -0000 1.97
+++ defs.h 27 Sep 2002 21:30:38 -0000
@@ -24,15 +24,16 @@
#ifndef DEFS_H
#define DEFS_H
-#include "config.h" /* Generated by configure */
+#include "config.h" /* Generated by configure. */
+
#include <stdio.h>
-#include <errno.h> /* System call error return status */
+#include <errno.h> /* System call error return status. */
#include <limits.h>
#ifdef HAVE_STDDEF_H
#include <stddef.h>
#else
-#include <sys/types.h> /* for size_t */
+#include <sys/types.h> /* For size_t. */
#endif
#ifdef HAVE_UNISTD_H
@@ -44,7 +45,7 @@
/* For ``enum target_signal''. */
#include "gdb/signals.h"
-/* Just in case they're not defined in stdio.h. */
+/* Just in case they're not defined in stdio.h. */
#ifndef SEEK_SET
#define SEEK_SET 0
@@ -58,7 +59,7 @@
#include "ansidecl.h"
-#include <stdarg.h> /* for va_list */
+#include <stdarg.h> /* For va_list. */
#include "libiberty.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Re-order includes in defs.h
2002-09-27 14:34 [PATCH] Re-order includes in defs.h Mark Kettenis
@ 2002-09-27 14:57 ` Andrew Cagney
2002-09-27 15:09 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2002-09-27 14:57 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
> This re-orders the includes on defs.h a bit to avoid problems with
> PARAMS getting multiply defined.
>
> Checked in on the trunk. If this doesn't lead to any problems, I'll probably move it over to the branch.
>
> Mark
>
>
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * defs.h: Move inclusion of "ansidecl.h" before "gdb_locale.h".
> Fix some whitespace problems.
Um, where is the gdb_locale.h part of the change?
Andrew
> Index: defs.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/defs.h,v
> retrieving revision 1.97
> diff -u -p -r1.97 defs.h
> --- defs.h 19 Sep 2002 03:58:41 -0000 1.97
> +++ defs.h 27 Sep 2002 21:30:38 -0000
> @@ -24,15 +24,16 @@
> #ifndef DEFS_H
> #define DEFS_H
>
> -#include "config.h" /* Generated by configure */
> +#include "config.h" /* Generated by configure. */
> +
> #include <stdio.h>
> -#include <errno.h> /* System call error return status */
> +#include <errno.h> /* System call error return status. */
> #include <limits.h>
>
> #ifdef HAVE_STDDEF_H
> #include <stddef.h>
> #else
> -#include <sys/types.h> /* for size_t */
> +#include <sys/types.h> /* For size_t. */
> #endif
>
> #ifdef HAVE_UNISTD_H
> @@ -44,7 +45,7 @@
> /* For ``enum target_signal''. */
> #include "gdb/signals.h"
>
> -/* Just in case they're not defined in stdio.h. */
> +/* Just in case they're not defined in stdio.h. */
>
> #ifndef SEEK_SET
> #define SEEK_SET 0
> @@ -58,7 +59,7 @@
>
> #include "ansidecl.h"
>
> -#include <stdarg.h> /* for va_list */
> +#include <stdarg.h> /* For va_list. */
>
> #include "libiberty.h"
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Re-order includes in defs.h
2002-09-27 14:57 ` Andrew Cagney
@ 2002-09-27 15:09 ` Mark Kettenis
0 siblings, 0 replies; 3+ messages in thread
From: Mark Kettenis @ 2002-09-27 15:09 UTC (permalink / raw)
To: ac131313; +Cc: gdb-patches
Date: Fri, 27 Sep 2002 17:57:13 -0400
From: Andrew Cagney <ac131313@redhat.com>
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * defs.h: Move inclusion of "ansidecl.h" before "gdb_locale.h".
> Fix some whitespace problems.
Um, where is the gdb_locale.h part of the change?
Ouch...
...here it is. I checked this in on top of the other patch.
Index: defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.98
diff -u -p -r1.98 defs.h
--- defs.h 27 Sep 2002 21:31:22 -0000 1.98
+++ defs.h 27 Sep 2002 22:04:39 -0000
@@ -40,6 +40,11 @@
#include <unistd.h>
#endif
+/* First include ansidecl.h so we can use the various macro definitions
+ here and in all subsequent file inclusions. */
+
+#include "ansidecl.h"
+
#include "gdb_locale.h"
/* For ``enum target_signal''. */
@@ -53,11 +58,6 @@
#ifndef SEEK_CUR
#define SEEK_CUR 1
#endif
-
-/* First include ansidecl.h so we can use the various macro definitions
- here and in all subsequent file inclusions. */
-
-#include "ansidecl.h"
#include <stdarg.h> /* For va_list. */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-09-27 22:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-27 14:34 [PATCH] Re-order includes in defs.h Mark Kettenis
2002-09-27 14:57 ` Andrew Cagney
2002-09-27 15:09 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox