From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19011-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32094 invoked by alias); 27 Sep 2002 21:57:15 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32069 invoked from network); 27 Sep 2002 21:57:13 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 27 Sep 2002 21:57:13 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 2C1D23E77; Fri, 27 Sep 2002 17:57:13 -0400 (EDT)
Message-ID: <3D94D439.1080708@redhat.com>
Date: Fri, 27 Sep 2002 14:57:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Re-order includes in defs.h
References: <200209272134.g8RLYdca026800@elgar.kettenis.dyndns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-09/txt/msg00685.txt.bz2

> This re-orders the includes on defs.h a bit to avoid problems with
> PARAMS getting multiply defined.
> 
> Checked in on the trunk.  If this doesn't lead to any problems, I'll probably move it over to the branch.
> 
> Mark
> 
> 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* defs.h: Move inclusion of "ansidecl.h" before "gdb_locale.h".
> 	Fix some whitespace problems.

Um, where is the gdb_locale.h part of the change?

Andrew


> Index: defs.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/defs.h,v
> retrieving revision 1.97
> diff -u -p -r1.97 defs.h
> --- defs.h 19 Sep 2002 03:58:41 -0000 1.97
> +++ defs.h 27 Sep 2002 21:30:38 -0000
> @@ -24,15 +24,16 @@
>  #ifndef DEFS_H
>  #define DEFS_H
>  
> -#include "config.h"		/* Generated by configure */
> +#include "config.h"		/* Generated by configure.  */
> +
>  #include <stdio.h>
> -#include <errno.h>		/* System call error return status */
> +#include <errno.h>		/* System call error return status.  */
>  #include <limits.h>
>  
>  #ifdef HAVE_STDDEF_H
>  #include <stddef.h>
>  #else
> -#include <sys/types.h>		/* for size_t */
> +#include <sys/types.h>		/* For size_t.  */
>  #endif
>  
>  #ifdef HAVE_UNISTD_H
> @@ -44,7 +45,7 @@
>  /* For ``enum target_signal''.  */
>  #include "gdb/signals.h"
>  
> -/* Just in case they're not defined in stdio.h. */
> +/* Just in case they're not defined in stdio.h.  */
>  
>  #ifndef SEEK_SET
>  #define SEEK_SET 0
> @@ -58,7 +59,7 @@
>  
>  #include "ansidecl.h"
>  
> -#include <stdarg.h>		/* for va_list */
> +#include <stdarg.h>		/* For va_list.  */
>  
>  #include "libiberty.h"
>  
>