Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Re-order includes in defs.h
Date: Fri, 27 Sep 2002 14:57:00 -0000	[thread overview]
Message-ID: <3D94D439.1080708@redhat.com> (raw)
In-Reply-To: <200209272134.g8RLYdca026800@elgar.kettenis.dyndns.org>

> This re-orders the includes on defs.h a bit to avoid problems with
> PARAMS getting multiply defined.
> 
> Checked in on the trunk.  If this doesn't lead to any problems, I'll probably move it over to the branch.
> 
> Mark
> 
> 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* defs.h: Move inclusion of "ansidecl.h" before "gdb_locale.h".
> 	Fix some whitespace problems.

Um, where is the gdb_locale.h part of the change?

Andrew


> Index: defs.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/defs.h,v
> retrieving revision 1.97
> diff -u -p -r1.97 defs.h
> --- defs.h 19 Sep 2002 03:58:41 -0000 1.97
> +++ defs.h 27 Sep 2002 21:30:38 -0000
> @@ -24,15 +24,16 @@
>  #ifndef DEFS_H
>  #define DEFS_H
>  
> -#include "config.h"		/* Generated by configure */
> +#include "config.h"		/* Generated by configure.  */
> +
>  #include <stdio.h>
> -#include <errno.h>		/* System call error return status */
> +#include <errno.h>		/* System call error return status.  */
>  #include <limits.h>
>  
>  #ifdef HAVE_STDDEF_H
>  #include <stddef.h>
>  #else
> -#include <sys/types.h>		/* for size_t */
> +#include <sys/types.h>		/* For size_t.  */
>  #endif
>  
>  #ifdef HAVE_UNISTD_H
> @@ -44,7 +45,7 @@
>  /* For ``enum target_signal''.  */
>  #include "gdb/signals.h"
>  
> -/* Just in case they're not defined in stdio.h. */
> +/* Just in case they're not defined in stdio.h.  */
>  
>  #ifndef SEEK_SET
>  #define SEEK_SET 0
> @@ -58,7 +59,7 @@
>  
>  #include "ansidecl.h"
>  
> -#include <stdarg.h>		/* for va_list */
> +#include <stdarg.h>		/* For va_list.  */
>  
>  #include "libiberty.h"
>  
> 



  reply	other threads:[~2002-09-27 21:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-27 14:34 Mark Kettenis
2002-09-27 14:57 ` Andrew Cagney [this message]
2002-09-27 15:09   ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D94D439.1080708@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox