* [RFA] default.exp checks wrong string
@ 2002-09-09 9:32 Corinna Vinschen
2002-09-09 11:05 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Corinna Vinschen @ 2002-09-09 9:32 UTC (permalink / raw)
To: gdb-patches
Hi,
the following patch fixes a wrong check in default.exp. While the function
infcmd.c:print_float_info() prints
"No floating-point info available for this processor."
the corresponding check in default.exp expects
"No floating point info available for this processor."
which can result in a failing test due to the missing dash.
To keep it backward compatible, the below patch doesn't use a dash but a
dot to allow any character at that point.
ChangeLog:
* gdb.base/default.exp: Fix expected string in `info float' test.
Index: testsuite/gdb.base/default.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
retrieving revision 1.12
diff -u -p -r1.12 default.exp
--- testsuite/gdb.base/default.exp 8 May 2002 21:05:44 -0000 1.12
+++ testsuite/gdb.base/default.exp 9 Sep 2002 15:04:04 -0000
@@ -327,7 +327,7 @@ if { [istarget "arm*-*-*"] || \
} elseif [istarget "i\[3456\]86-*-*"] then {
gdb_test "info float" "R7:.*Status Word:.*Opcode:.*" "info float"
} else {
- gdb_test "info float" "No floating point info available for this processor." "info float"
+ gdb_test "info float" "No floating.point info available for this processor." "info float"
}
#test info functions
gdb_test "info functions" "All defined functions:" "info functions"
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] default.exp checks wrong string
2002-09-09 9:32 [RFA] default.exp checks wrong string Corinna Vinschen
@ 2002-09-09 11:05 ` Andrew Cagney
2002-09-10 0:06 ` Corinna Vinschen
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2002-09-09 11:05 UTC (permalink / raw)
To: Corinna Vinschen, Fernando Nasser; +Cc: gdb-patches
> Hi,
>
> the following patch fixes a wrong check in default.exp. While the function
> infcmd.c:print_float_info() prints
>
> "No floating-point info available for this processor."
>
> the corresponding check in default.exp expects
>
> "No floating point info available for this processor."
>
> which can result in a failing test due to the missing dash.
>
> To keep it backward compatible, the below patch doesn't use a dash but a
> dot to allow any character at that point.
Hmm, there is a chance here, that I botched the string, while making
other changes -> the error is in infcmd.c. Perhaphs check what the
string reads in 5.2.x. Either way, fixing this is pretty obvious.
enjoy,
Andrew
> ChangeLog:
>
> * gdb.base/default.exp: Fix expected string in `info float' test.
>
> Index: testsuite/gdb.base/default.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
> retrieving revision 1.12
> diff -u -p -r1.12 default.exp
> --- testsuite/gdb.base/default.exp 8 May 2002 21:05:44 -0000 1.12
> +++ testsuite/gdb.base/default.exp 9 Sep 2002 15:04:04 -0000
> @@ -327,7 +327,7 @@ if { [istarget "arm*-*-*"] || \
> } elseif [istarget "i\[3456\]86-*-*"] then {
> gdb_test "info float" "R7:.*Status Word:.*Opcode:.*" "info float"
> } else {
> - gdb_test "info float" "No floating point info available for this processor." "info float"
> + gdb_test "info float" "No floating.point info available for this processor." "info float"
> }
> #test info functions
> gdb_test "info functions" "All defined functions:" "info functions"
>
>
> Corinna
>
> -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer mailto:cygwin@cygwin.com Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-09-10 7:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-09 9:32 [RFA] default.exp checks wrong string Corinna Vinschen
2002-09-09 11:05 ` Andrew Cagney
2002-09-10 0:06 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox