From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-18450-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 15819 invoked by alias); 9 Sep 2002 18:05:41 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15812 invoked from network); 9 Sep 2002 18:05:40 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 9 Sep 2002 18:05:40 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id ED6633F26; Mon,  9 Sep 2002 14:05:40 -0400 (EDT)
Message-ID: <3D7CE2F4.9060300@ges.redhat.com>
Date: Mon, 09 Sep 2002 11:05:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Corinna Vinschen <vinschen@redhat.com>,
	Fernando Nasser <fnasser@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] default.exp checks wrong string
References: <20020909183220.Y1574@cygbert.vinschen.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-09/txt/msg00124.txt.bz2

> Hi,
> 
> the following patch fixes a wrong check in default.exp.  While the function
> infcmd.c:print_float_info() prints
> 
>   "No floating-point info available for this processor."
> 
> the corresponding check in default.exp expects
> 
>   "No floating point info available for this processor."
> 
> which can result in a failing test due to the missing dash.
> 
> To keep it backward compatible, the below patch doesn't use a dash but a
> dot to allow any character at that point.

Hmm, there is a chance here, that I botched the string, while making 
other changes -> the error is in infcmd.c.  Perhaphs check what the 
string reads in 5.2.x.  Either way, fixing this is pretty obvious.

enjoy,
Andrew


> ChangeLog:
> 
> 	* gdb.base/default.exp: Fix expected string in `info float' test.
> 
> Index: testsuite/gdb.base/default.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
> retrieving revision 1.12
> diff -u -p -r1.12 default.exp
> --- testsuite/gdb.base/default.exp	8 May 2002 21:05:44 -0000	1.12
> +++ testsuite/gdb.base/default.exp	9 Sep 2002 15:04:04 -0000
> @@ -327,7 +327,7 @@ if { [istarget "arm*-*-*"] || \
>  } elseif [istarget "i\[3456\]86-*-*"] then {
>      gdb_test "info float" "R7:.*Status Word:.*Opcode:.*" "info float"
>  } else {
> -    gdb_test "info float" "No floating point info available for this processor." "info float"
> +    gdb_test "info float" "No floating.point info available for this processor." "info float"
>  }
>  #test info functions
>  gdb_test "info functions" "All defined functions:" "info functions"
> 
> 
> Corinna
> 
> -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer mailto:cygwin@cygwin.com Red Hat, Inc.