From: Andrew Cagney <ac131313@ges.redhat.com>
To: Corinna Vinschen <vinschen@redhat.com>,
Fernando Nasser <fnasser@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] default.exp checks wrong string
Date: Mon, 09 Sep 2002 11:05:00 -0000 [thread overview]
Message-ID: <3D7CE2F4.9060300@ges.redhat.com> (raw)
In-Reply-To: <20020909183220.Y1574@cygbert.vinschen.de>
> Hi,
>
> the following patch fixes a wrong check in default.exp. While the function
> infcmd.c:print_float_info() prints
>
> "No floating-point info available for this processor."
>
> the corresponding check in default.exp expects
>
> "No floating point info available for this processor."
>
> which can result in a failing test due to the missing dash.
>
> To keep it backward compatible, the below patch doesn't use a dash but a
> dot to allow any character at that point.
Hmm, there is a chance here, that I botched the string, while making
other changes -> the error is in infcmd.c. Perhaphs check what the
string reads in 5.2.x. Either way, fixing this is pretty obvious.
enjoy,
Andrew
> ChangeLog:
>
> * gdb.base/default.exp: Fix expected string in `info float' test.
>
> Index: testsuite/gdb.base/default.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
> retrieving revision 1.12
> diff -u -p -r1.12 default.exp
> --- testsuite/gdb.base/default.exp 8 May 2002 21:05:44 -0000 1.12
> +++ testsuite/gdb.base/default.exp 9 Sep 2002 15:04:04 -0000
> @@ -327,7 +327,7 @@ if { [istarget "arm*-*-*"] || \
> } elseif [istarget "i\[3456\]86-*-*"] then {
> gdb_test "info float" "R7:.*Status Word:.*Opcode:.*" "info float"
> } else {
> - gdb_test "info float" "No floating point info available for this processor." "info float"
> + gdb_test "info float" "No floating.point info available for this processor." "info float"
> }
> #test info functions
> gdb_test "info functions" "All defined functions:" "info functions"
>
>
> Corinna
>
> -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer mailto:cygwin@cygwin.com Red Hat, Inc.
next prev parent reply other threads:[~2002-09-09 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-09 9:32 Corinna Vinschen
2002-09-09 11:05 ` Andrew Cagney [this message]
2002-09-10 0:06 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D7CE2F4.9060300@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox