From: Andrew Cagney <ac131313@ges.redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Minor reformatting in infrun.c
Date: Fri, 23 Aug 2002 15:23:00 -0000 [thread overview]
Message-ID: <3D66B233.6030201@ges.redhat.com> (raw)
In-Reply-To: <20020823220232.GB25997@gnat.com>
>
> Absolutely. But unfortunately this is not the way indent formats it:
>
> <<
> stop_bpstat =
> bpstat_stop_status
> (&stop_pc,
> sw_single_step_trap_p
> || (currently_stepping (ecs)
> && prev_pc != stop_pc - DECR_PC_AFTER_BREAK
> && !(step_range_end
> && INNER_THAN (read_sp (), (step_sp - 16)))));
>
Why not just do:
int not_a_sw_breakpoint = ......
stop_bpstat = ..., not_a_sw_breakpoint, ...
the expression is unreasonably complex anyway :-)
enjoy,
Andrew
next prev parent reply other threads:[~2002-08-23 22:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-16 17:18 Joel Brobecker
2002-08-16 19:48 ` Michael Snyder
2002-08-22 16:52 ` Joel Brobecker
2002-08-22 18:25 ` Michael Snyder
2002-08-23 10:29 ` Joel Brobecker
2002-08-23 11:31 ` Michael Snyder
2002-08-23 15:06 ` Joel Brobecker
2002-08-23 15:23 ` Andrew Cagney [this message]
2002-08-23 16:15 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D66B233.6030201@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox