From: Michael Snyder <msnyder@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Minor reformatting in infrun.c
Date: Fri, 23 Aug 2002 11:31:00 -0000 [thread overview]
Message-ID: <3D667E8E.8616E88F@redhat.com> (raw)
In-Reply-To: <20020823162729.GZ25997@gnat.com>
Joel Brobecker wrote:
>
> > Err, I was actually meaning to say "let's conform with indent",
> > rather than "let's defeat indent". How about moving the comment
> > outside the argument list? Then the args can stay as they were.
>
> I see what you mean now. I should have tried it before, instead of
> assuming that moving the comment up would not prevent indent from
> formatting the args back to the same previous unreadable way (I did not
> realize that the comment had this effect in the formatting result)...
>
> I can commit the following patch. I verified that a later re-indent
> does not cause a formatting change in the second argument.
Yes, and now I can see no reason not to put the arguments back
the way they were originally. Or, say.
stop_bpstat =
bpstat_stop_status (&stop_pc,
[...]
I think it's more natural and readable than moving the paren down.
> 2002-08-23 Joel Brobecker <brobecker@gnat.com>
>
> * infrun.c (handle_inferior_event): Move a comment outside of a
> function call, in order to avoid indent reformatting this part
> of the code in an unreadable way.
>
> --
> Joel
>
> ------------------------------------------------------------------------
>
> infrun.c.diffName: infrun.c.diff
> Type: Plain Text (text/plain)
next prev parent reply other threads:[~2002-08-23 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-16 17:18 Joel Brobecker
2002-08-16 19:48 ` Michael Snyder
2002-08-22 16:52 ` Joel Brobecker
2002-08-22 18:25 ` Michael Snyder
2002-08-23 10:29 ` Joel Brobecker
2002-08-23 11:31 ` Michael Snyder [this message]
2002-08-23 15:06 ` Joel Brobecker
2002-08-23 15:23 ` Andrew Cagney
2002-08-23 16:15 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D667E8E.8616E88F@redhat.com \
--to=msnyder@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox