From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29715 invoked by alias); 23 Aug 2002 18:27:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29708 invoked from network); 23 Aug 2002 18:27:27 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 23 Aug 2002 18:27:27 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA21369; Fri, 23 Aug 2002 11:21:22 -0700 (PDT) Message-ID: <3D667E8E.8616E88F@redhat.com> Date: Fri, 23 Aug 2002 11:31:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Minor reformatting in infrun.c References: <20020817001848.GX906@gnat.com> <3D5DB58E.3A856EB3@redhat.com> <20020822234116.GU25997@gnat.com> <3D657A41.EBE52A4B@redhat.com> <20020823162729.GZ25997@gnat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00759.txt.bz2 Joel Brobecker wrote: > > > Err, I was actually meaning to say "let's conform with indent", > > rather than "let's defeat indent". How about moving the comment > > outside the argument list? Then the args can stay as they were. > > I see what you mean now. I should have tried it before, instead of > assuming that moving the comment up would not prevent indent from > formatting the args back to the same previous unreadable way (I did not > realize that the comment had this effect in the formatting result)... > > I can commit the following patch. I verified that a later re-indent > does not cause a formatting change in the second argument. Yes, and now I can see no reason not to put the arguments back the way they were originally. Or, say. stop_bpstat = bpstat_stop_status (&stop_pc, [...] I think it's more natural and readable than moving the paren down. > 2002-08-23 Joel Brobecker > > * infrun.c (handle_inferior_event): Move a comment outside of a > function call, in order to avoid indent reformatting this part > of the code in an unreadable way. > > -- > Joel > > ------------------------------------------------------------------------ > > infrun.c.diffName: infrun.c.diff > Type: Plain Text (text/plain)