From: Joel Brobecker <brobecker@gnat.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Minor reformatting in infrun.c
Date: Thu, 22 Aug 2002 16:52:00 -0000 [thread overview]
Message-ID: <20020822234116.GU25997@gnat.com> (raw)
In-Reply-To: <3D5DB58E.3A856EB3@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
> I hate long lines as much as anybody, but I hate defeating indent
> even more. The middle part of this is just going to go back to
> the right again, the first time indent gets run.
>
> You might prefer to have it happen under your control...
Argh! That's right! Thanks.
After adding the followig dummy comment, the "indent"-ed version stays
very close to the hand-formatted version. Should I check it in?
(note, the attached patch does not include the changes introduced after
running gdb_indent).
2002-08-22 Joel Brobecker <brobecker@gnat.com>
* infrun.c (handle_inferior_event): Add a dummy comment to
help indent find a more readable formatting of this line of code.
Thanks,
--
Joel
[-- Attachment #2: infrun.c.diff --]
[-- Type: text/plain, Size: 991 bytes --]
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.68
diff -c -3 -p -r1.68 infrun.c
*** infrun.c 20 Aug 2002 23:01:29 -0000 1.68
--- infrun.c 22 Aug 2002 23:31:08 -0000
*************** handle_inferior_event (struct execution_
*** 2113,2119 ****
jump to the instruction following a trap instruction. */
stop_bpstat =
! bpstat_stop_status
(&stop_pc,
/* Pass TRUE if our reason for stopping is something other
than hitting a breakpoint. We do this by checking that
--- 2113,2119 ----
jump to the instruction following a trap instruction. */
stop_bpstat =
! bpstat_stop_status /* Force indent line break here */
(&stop_pc,
/* Pass TRUE if our reason for stopping is something other
than hitting a breakpoint. We do this by checking that
next prev parent reply other threads:[~2002-08-22 23:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-16 17:18 Joel Brobecker
2002-08-16 19:48 ` Michael Snyder
2002-08-22 16:52 ` Joel Brobecker [this message]
2002-08-22 18:25 ` Michael Snyder
2002-08-23 10:29 ` Joel Brobecker
2002-08-23 11:31 ` Michael Snyder
2002-08-23 15:06 ` Joel Brobecker
2002-08-23 15:23 ` Andrew Cagney
2002-08-23 16:15 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020822234116.GU25997@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox