From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14336 invoked by alias); 22 Aug 2002 23:41:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14325 invoked from network); 22 Aug 2002 23:41:14 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (205.232.38.247) by sources.redhat.com with SMTP; 22 Aug 2002 23:41:14 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id A4056D2CBD; Thu, 22 Aug 2002 16:41:16 -0700 (PDT) Date: Thu, 22 Aug 2002 16:52:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Minor reformatting in infrun.c Message-ID: <20020822234116.GU25997@gnat.com> References: <20020817001848.GX906@gnat.com> <3D5DB58E.3A856EB3@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Fba/0zbH8Xs+Fj9o" Content-Disposition: inline In-Reply-To: <3D5DB58E.3A856EB3@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2002-08/txt/msg00739.txt.bz2 --Fba/0zbH8Xs+Fj9o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 716 > I hate long lines as much as anybody, but I hate defeating indent > even more. The middle part of this is just going to go back to > the right again, the first time indent gets run. > > You might prefer to have it happen under your control... Argh! That's right! Thanks. After adding the followig dummy comment, the "indent"-ed version stays very close to the hand-formatted version. Should I check it in? (note, the attached patch does not include the changes introduced after running gdb_indent). 2002-08-22 Joel Brobecker * infrun.c (handle_inferior_event): Add a dummy comment to help indent find a more readable formatting of this line of code. Thanks, -- Joel --Fba/0zbH8Xs+Fj9o Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="infrun.c.diff" Content-length: 991 Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.68 diff -c -3 -p -r1.68 infrun.c *** infrun.c 20 Aug 2002 23:01:29 -0000 1.68 --- infrun.c 22 Aug 2002 23:31:08 -0000 *************** handle_inferior_event (struct execution_ *** 2113,2119 **** jump to the instruction following a trap instruction. */ stop_bpstat = ! bpstat_stop_status (&stop_pc, /* Pass TRUE if our reason for stopping is something other than hitting a breakpoint. We do this by checking that --- 2113,2119 ---- jump to the instruction following a trap instruction. */ stop_bpstat = ! bpstat_stop_status /* Force indent line break here */ (&stop_pc, /* Pass TRUE if our reason for stopping is something other than hitting a breakpoint. We do this by checking that --Fba/0zbH8Xs+Fj9o--