From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20715 invoked by alias); 23 Aug 2002 22:07:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20708 invoked from network); 23 Aug 2002 22:07:51 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 23 Aug 2002 22:07:51 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D87133ED5; Fri, 23 Aug 2002 18:07:47 -0400 (EDT) Message-ID: <3D66B233.6030201@ges.redhat.com> Date: Fri, 23 Aug 2002 15:23:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Minor reformatting in infrun.c References: <20020817001848.GX906@gnat.com> <3D5DB58E.3A856EB3@redhat.com> <20020822234116.GU25997@gnat.com> <3D657A41.EBE52A4B@redhat.com> <20020823162729.GZ25997@gnat.com> <3D667E8E.8616E88F@redhat.com> <20020823220232.GB25997@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00777.txt.bz2 > > Absolutely. But unfortunately this is not the way indent formats it: > > << > stop_bpstat = > bpstat_stop_status > (&stop_pc, > sw_single_step_trap_p > || (currently_stepping (ecs) > && prev_pc != stop_pc - DECR_PC_AFTER_BREAK > && !(step_range_end > && INNER_THAN (read_sp (), (step_sp - 16))))); > Why not just do: int not_a_sw_breakpoint = ...... stop_bpstat = ..., not_a_sw_breakpoint, ... the expression is unreasonably complex anyway :-) enjoy, Andrew