* try_catch.cc -> try-catch.cc
@ 2002-05-29 10:08 Andrew Cagney
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Cagney @ 2002-05-29 10:08 UTC (permalink / raw)
To: Michael Elizabeth Chastain, gdb-patches
Just FYI,
The file try_catch.cc should be try-catch.cc
http://sources.redhat.com/gdb/onlinedocs/gdbint_13.html#SEC110
enjoy,
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: try_catch.cc -> try-catch.cc
@ 2002-05-29 12:01 Michael Elizabeth Chastain
2002-05-29 20:46 ` Andrew Cagney
0 siblings, 1 reply; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2002-05-29 12:01 UTC (permalink / raw)
To: cagney, gdb-patches
I actually thought about that. :) I believe this section applies:
http://sources.redhat.com/gdb/onlinedocs/gdbint_16.html#SEC157
The source language programs do @emph{not} need to be in a consistent
style. Since @value{GDBN} is used to debug programs written in many different
styles, it's worth having a mix of styles in the testsuite; for
instance, some @value{GDBN} bugs involving the display of source lines would
never manifest themselves if the programs used GNU coding style
uniformly.
I know it's unlikely that gdb will ever have a bug where it can't
handle '_' in a filename. (Although gdb does have filename completion).
It's more the principle of keeping the test suite programs diverse
and uncanonicalized.
I'll change it if you want it changed, though.
Michael C
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: try_catch.cc -> try-catch.cc
2002-05-29 12:01 Michael Elizabeth Chastain
@ 2002-05-29 20:46 ` Andrew Cagney
2002-05-30 1:42 ` Daniel Jacobowitz
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Cagney @ 2002-05-29 20:46 UTC (permalink / raw)
To: Michael Elizabeth Chastain; +Cc: gdb-patches
> I actually thought about that. :) I believe this section applies:
>
> http://sources.redhat.com/gdb/onlinedocs/gdbint_16.html#SEC157
> The source language programs do @emph{not} need to be in a consistent
> style. Since @value{GDBN} is used to debug programs written in many different
> styles, it's worth having a mix of styles in the testsuite; for
> instance, some @value{GDBN} bugs involving the display of source lines would
> never manifest themselves if the programs used GNU coding style
> uniformly.
>
> I know it's unlikely that gdb will ever have a bug where it can't
> handle '_' in a filename. (Although gdb does have filename completion).
> It's more the principle of keeping the test suite programs diverse
> and uncanonicalized.
(GDB will have bugs where it thinks try-catch.cc is `try - catch.cc' :-)
> I'll change it if you want it changed, though.
I see your point. I think here the question is more one of keeping the
test focused on exercising a specific feature - try/catch - rather than
a coding style issue.
Anyway, your call. (Hmm, we desperatly need some file name completer
tests including some containing spaces.)
enjoy,
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: try_catch.cc -> try-catch.cc
2002-05-29 20:46 ` Andrew Cagney
@ 2002-05-30 1:42 ` Daniel Jacobowitz
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Jacobowitz @ 2002-05-30 1:42 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Michael Elizabeth Chastain, gdb-patches
On Wed, May 29, 2002 at 11:32:19PM -0400, Andrew Cagney wrote:
> >I actually thought about that. :) I believe this section applies:
> >
> > http://sources.redhat.com/gdb/onlinedocs/gdbint_16.html#SEC157
> > The source language programs do @emph{not} need to be in a consistent
> > style. Since @value{GDBN} is used to debug programs written in many
> > different
> > styles, it's worth having a mix of styles in the testsuite; for
> > instance, some @value{GDBN} bugs involving the display of source lines
> > would
> > never manifest themselves if the programs used GNU coding style
> > uniformly.
> >
> >I know it's unlikely that gdb will ever have a bug where it can't
> >handle '_' in a filename. (Although gdb does have filename completion).
> >It's more the principle of keeping the test suite programs diverse
> >and uncanonicalized.
>
> (GDB will have bugs where it thinks try-catch.cc is `try - catch.cc' :-)
>
> >I'll change it if you want it changed, though.
>
> I see your point. I think here the question is more one of keeping the
> test focused on exercising a specific feature - try/catch - rather than
> a coding style issue.
>
> Anyway, your call. (Hmm, we desperatly need some file name completer
> tests including some containing spaces.)
I don't think CVS will let us get away with that, and I'm even more
sure djgpp will gripe. We'd need to create them at testsuite time,
which is tricky...
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: try_catch.cc -> try-catch.cc
@ 2002-05-29 22:00 Michael Elizabeth Chastain
0 siblings, 0 replies; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2002-05-29 22:00 UTC (permalink / raw)
To: ac131313; +Cc: gdb-patches
Andrew Cagney writes:
> Anyway, your call. (Hmm, we desperatly need some file name completer
> tests including some containing spaces.)
Thanks.
I'm going to go with try_catch.c, as is.
Michael C
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-05-30 5:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-29 10:08 try_catch.cc -> try-catch.cc Andrew Cagney
2002-05-29 12:01 Michael Elizabeth Chastain
2002-05-29 20:46 ` Andrew Cagney
2002-05-30 1:42 ` Daniel Jacobowitz
2002-05-29 22:00 Michael Elizabeth Chastain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox