From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5760 invoked by alias); 30 May 2002 05:00:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5737 invoked from network); 30 May 2002 05:00:57 -0000 Received: from unknown (HELO branoic) (12.234.96.134) by sources.redhat.com with SMTP; 30 May 2002 05:00:57 -0000 Received: from drow by branoic with local (Exim 3.35 #1 (Debian)) id 17DI3H-0002U9-00; Thu, 30 May 2002 01:00:43 -0400 Date: Thu, 30 May 2002 01:42:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: try_catch.cc -> try-catch.cc Message-ID: <20020530050043.GA9539@branoic.them.org> Mail-Followup-To: Andrew Cagney , Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <200205291708.g4TH81M02144@duracef.shout.net> <3CF59D43.4050201@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CF59D43.4050201@cygnus.com> User-Agent: Mutt/1.3.28i X-SW-Source: 2002-05/txt/msg01021.txt.bz2 On Wed, May 29, 2002 at 11:32:19PM -0400, Andrew Cagney wrote: > >I actually thought about that. :) I believe this section applies: > > > > http://sources.redhat.com/gdb/onlinedocs/gdbint_16.html#SEC157 > > The source language programs do @emph{not} need to be in a consistent > > style. Since @value{GDBN} is used to debug programs written in many > > different > > styles, it's worth having a mix of styles in the testsuite; for > > instance, some @value{GDBN} bugs involving the display of source lines > > would > > never manifest themselves if the programs used GNU coding style > > uniformly. > > > >I know it's unlikely that gdb will ever have a bug where it can't > >handle '_' in a filename. (Although gdb does have filename completion). > >It's more the principle of keeping the test suite programs diverse > >and uncanonicalized. > > (GDB will have bugs where it thinks try-catch.cc is `try - catch.cc' :-) > > >I'll change it if you want it changed, though. > > I see your point. I think here the question is more one of keeping the > test focused on exercising a specific feature - try/catch - rather than > a coding style issue. > > Anyway, your call. (Hmm, we desperatly need some file name completer > tests including some containing spaces.) I don't think CVS will let us get away with that, and I'm even more sure djgpp will gripe. We'd need to create them at testsuite time, which is tricky... -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer