[RFC] fix ARI whinge about remote-rdi.c usage of true/false

[RFC] fix ARI whinge about remote-rdi.c usage of true/false

[Richard Earnshaw]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]


The ARI script is currently whingeing incorrectly that remote-rdi.c is
using 'true' and 'false', presumably because it cannot detect that the use
is inside a multi-line string.  The following patch will clear this up, but
it relies on ANSI-style string concatenation.

Are there any issues with doing it this way?  In particular would this be
compatible with any future i18n work?

R.

	* remote-rdi.c (_initialize_remote_rdi): Use ANSI-style string 
	concatenation for help messages.



[-- Attachment #2: gdb-rdi-tf.patch --]
[-- Type: text/x-patch , Size: 3426 bytes --]

Index: remote-rdi.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-rdi.c,v
retrieving revision 1.22
diff -p -r1.22 remote-rdi.c
*** remote-rdi.c	7 Mar 2002 15:29:53 -0000	1.22
--- remote-rdi.c	7 May 2002 12:36:50 -0000
*************** _initialize_remote_rdi (void)
*** 1023,1061 ****
  
    c = add_cmd ("rdilogfile", class_maintenance,
  	       rdilogfile_command,
! 	       "Set filename for ADP packet log.\n\
! This file is used to log Angel Debugger Protocol packets.\n\
! With a single argument, sets the logfile name to that value.\n\
! Without an argument, shows the current logfile name.\n\
! See also: rdilogenable\n",
! 	   &maintenancelist);
    set_cmd_completer (c, filename_completer);
  
    add_cmd ("rdilogenable", class_maintenance,
  	   rdilogenable_command,
! 	   "Set enable logging of ADP packets.\n\
! This will log ADP packets exchanged between gdb and the\n\
! rdi target device.\n\
! An argument of 1,t,true,y,yes will enable.\n\
! An argument of 0,f,false,n,no will disabled.\n\
! Withough an argument, it will display current state.\n",
  	   &maintenancelist);
  
    add_show_from_set
!     (add_set_boolean_cmd ("rdiromatzero", no_class, &rom_at_zero,
! 			  "Set target has ROM at addr 0.\n\
! A true value disables vector catching, false enables vector catching.\n\
! This is evaluated at the time the 'target rdi' command is executed\n",
! 			  &setlist),
       &showlist);
  
    add_show_from_set
!     (add_set_boolean_cmd ("rdiheartbeat", no_class, &rdi_heartbeat,
! 			  "Set enable for ADP heartbeat packets.\n\
! I don't know why you would want this. If you enable them,\n\
! it will confuse ARM and EPI JTAG interface boxes as well\n\
! as the Angel Monitor.\n",
! 			  &setlist),
       &showlist);
  }
  
--- 1023,1063 ----
  
    c = add_cmd ("rdilogfile", class_maintenance,
  	       rdilogfile_command,
! 	       "Set filename for ADP packet log.\n"
! 	       "This file is used to log Angel Debugger Protocol packets.\n"
! 	       "With a single argument, sets the logfile name to that value.\n"
! 	       "Without an argument, shows the current logfile name.\n"
! 	       "See also: rdilogenable\n",
! 	       &maintenancelist);
    set_cmd_completer (c, filename_completer);
  
    add_cmd ("rdilogenable", class_maintenance,
  	   rdilogenable_command,
! 	   "Set enable logging of ADP packets.\n"
! 	   "This will log ADP packets exchanged between gdb and the\n"
! 	   "rdi target device.\n"
! 	   "An argument of 1, t, true, y or yes will enable.\n"
! 	   "An argument of 0, f, false, n or no will disabled.\n"
! 	   "Withough an argument, it will display current state.\n",
  	   &maintenancelist);
  
    add_show_from_set
!     (add_set_boolean_cmd
!      ("rdiromatzero", no_class, &rom_at_zero,
!       "Set target has ROM at addr 0.\n"
!       "A true value disables vector catching, false enables vector catching.\n"
!       "This is evaluated at the time the 'target rdi' command is executed\n",
!       &setlist),
       &showlist);
  
    add_show_from_set
!     (add_set_boolean_cmd
!      ("rdiheartbeat", no_class, &rdi_heartbeat,
!       "Set enable for ADP heartbeat packets.\n"
!       "I don't know why you would want this. If you enable them,\n"
!       "it will confuse ARM and EPI JTAG interface boxes as well\n"
!       "as the Angel Monitor.\n",
!       &setlist),
       &showlist);
  }
  

Re: [RFC] fix ARI whinge about remote-rdi.c usage of true/false

[Daniel Jacobowitz]

On Tue, May 07, 2002 at 01:41:21PM +0100, Richard Earnshaw wrote:
> 
> The ARI script is currently whingeing incorrectly that remote-rdi.c is
> using 'true' and 'false', presumably because it cannot detect that the use
> is inside a multi-line string.  The following patch will clear this up, but
> it relies on ANSI-style string concatenation.
> 
> Are there any issues with doing it this way?  In particular would this be
> compatible with any future i18n work?
> 
> R.
> 
> 	* remote-rdi.c (_initialize_remote_rdi): Use ANSI-style string 
> 	concatenation for help messages.
> 
> 

This should be fine; multiline strings are handled correctly by
gettext, and GDB already contains string concatenation.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFC] fix ARI whinge about remote-rdi.c usage of true/false

[Andrew Cagney]

> The ARI script is currently whingeing incorrectly that remote-rdi.c is
> using 'true' and 'false', presumably because it cannot detect that the use
> is inside a multi-line string.  The following patch will clear this up, but
> it relies on ANSI-style string concatenation.
> 
> Are there any issues with doing it this way?  In particular would this be
> compatible with any future i18n work?

Er, sorry, ignore that ARI entry - I was fixing the AWK that strips 
strings only I didn't - it would be silly to not be able to use the word 
`true' in a string.

I think I've fixed it, try refreshing:

	http://sources.redhat.com/gdb/current/ari/

sorry,
Andrew


> 
> 	* remote-rdi.c (_initialize_remote_rdi): Use ANSI-style string 
> 	concatenation for help messages.
> 
> 

Re: [RFC] fix ARI whinge about remote-rdi.c usage of true/false

[Richard Earnshaw]

> Er, sorry, ignore that ARI entry - I was fixing the AWK that strips 
> strings only I didn't - it would be silly to not be able to use the word 
> `true' in a string.

Ok, but regardless of the whinge, unless the patch will cause problems I 
would prefer to commit it.  For starters it saves diff -p from getting 
confused when detecting the function name.

R.