From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15274 invoked by alias); 7 May 2002 12:42:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15250 invoked from network); 7 May 2002 12:42:07 -0000 Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3) by sources.redhat.com with SMTP; 7 May 2002 12:42:07 -0000 Received: by fw-cam.cambridge.arm.com; id NAA15066; Tue, 7 May 2002 13:42:05 +0100 (BST) Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5) id xma013924; Tue, 7 May 02 13:41:22 +0100 Received: from cam-mail2.cambridge.arm.com (cam-mail2.cambridge.arm.com [172.16.1.91]) by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id NAA14626 for ; Tue, 7 May 2002 13:41:22 +0100 (BST) Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18]) by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id NAA18595; Tue, 7 May 2002 13:41:22 +0100 (BST) Message-Id: <200205071241.NAA18595@cam-mail2.cambridge.arm.com> To: gdb-patches@sources.redhat.com cc: Richard.Earnshaw@arm.com Reply-To: Richard.Earnshaw@arm.com Organization: ARM Ltd. X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd) X-Fax: +44 1223 400410 X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ. X-Url: http://www.arm.com/ Subject: [RFC] fix ARI whinge about remote-rdi.c usage of true/false Mime-Version: 1.0 Content-Type: multipart/mixed ; boundary="==_Exmh_-6066365620" Date: Tue, 07 May 2002 05:42:00 -0000 From: Richard Earnshaw X-SW-Source: 2002-05/txt/msg00146.txt.bz2 This is a multipart MIME message. --==_Exmh_-6066365620 Content-Type: text/plain; charset=us-ascii Content-length: 488 The ARI script is currently whingeing incorrectly that remote-rdi.c is using 'true' and 'false', presumably because it cannot detect that the use is inside a multi-line string. The following patch will clear this up, but it relies on ANSI-style string concatenation. Are there any issues with doing it this way? In particular would this be compatible with any future i18n work? R. * remote-rdi.c (_initialize_remote_rdi): Use ANSI-style string concatenation for help messages. --==_Exmh_-6066365620 Content-Type: text/x-patch ; name="gdb-rdi-tf.patch"; charset=us-ascii Content-Description: gdb-rdi-tf.patch Content-Disposition: attachment; filename="gdb-rdi-tf.patch" Content-length: 3426 Index: remote-rdi.c =================================================================== RCS file: /cvs/src/src/gdb/remote-rdi.c,v retrieving revision 1.22 diff -p -r1.22 remote-rdi.c *** remote-rdi.c 7 Mar 2002 15:29:53 -0000 1.22 --- remote-rdi.c 7 May 2002 12:36:50 -0000 *************** _initialize_remote_rdi (void) *** 1023,1061 **** c = add_cmd ("rdilogfile", class_maintenance, rdilogfile_command, ! "Set filename for ADP packet log.\n\ ! This file is used to log Angel Debugger Protocol packets.\n\ ! With a single argument, sets the logfile name to that value.\n\ ! Without an argument, shows the current logfile name.\n\ ! See also: rdilogenable\n", ! &maintenancelist); set_cmd_completer (c, filename_completer); add_cmd ("rdilogenable", class_maintenance, rdilogenable_command, ! "Set enable logging of ADP packets.\n\ ! This will log ADP packets exchanged between gdb and the\n\ ! rdi target device.\n\ ! An argument of 1,t,true,y,yes will enable.\n\ ! An argument of 0,f,false,n,no will disabled.\n\ ! Withough an argument, it will display current state.\n", &maintenancelist); add_show_from_set ! (add_set_boolean_cmd ("rdiromatzero", no_class, &rom_at_zero, ! "Set target has ROM at addr 0.\n\ ! A true value disables vector catching, false enables vector catching.\n\ ! This is evaluated at the time the 'target rdi' command is executed\n", ! &setlist), &showlist); add_show_from_set ! (add_set_boolean_cmd ("rdiheartbeat", no_class, &rdi_heartbeat, ! "Set enable for ADP heartbeat packets.\n\ ! I don't know why you would want this. If you enable them,\n\ ! it will confuse ARM and EPI JTAG interface boxes as well\n\ ! as the Angel Monitor.\n", ! &setlist), &showlist); } --- 1023,1063 ---- c = add_cmd ("rdilogfile", class_maintenance, rdilogfile_command, ! "Set filename for ADP packet log.\n" ! "This file is used to log Angel Debugger Protocol packets.\n" ! "With a single argument, sets the logfile name to that value.\n" ! "Without an argument, shows the current logfile name.\n" ! "See also: rdilogenable\n", ! &maintenancelist); set_cmd_completer (c, filename_completer); add_cmd ("rdilogenable", class_maintenance, rdilogenable_command, ! "Set enable logging of ADP packets.\n" ! "This will log ADP packets exchanged between gdb and the\n" ! "rdi target device.\n" ! "An argument of 1, t, true, y or yes will enable.\n" ! "An argument of 0, f, false, n or no will disabled.\n" ! "Withough an argument, it will display current state.\n", &maintenancelist); add_show_from_set ! (add_set_boolean_cmd ! ("rdiromatzero", no_class, &rom_at_zero, ! "Set target has ROM at addr 0.\n" ! "A true value disables vector catching, false enables vector catching.\n" ! "This is evaluated at the time the 'target rdi' command is executed\n", ! &setlist), &showlist); add_show_from_set ! (add_set_boolean_cmd ! ("rdiheartbeat", no_class, &rdi_heartbeat, ! "Set enable for ADP heartbeat packets.\n" ! "I don't know why you would want this. If you enable them,\n" ! "it will confuse ARM and EPI JTAG interface boxes as well\n" ! "as the Angel Monitor.\n", ! &setlist), &showlist); } --==_Exmh_-6066365620--