* [RFA] Mark Sparc/Linux as multi-arch
@ 2002-04-19 15:40 David S. Miller
2002-04-19 16:35 ` Andrew Cagney
2002-04-19 18:32 ` Michael Snyder
0 siblings, 2 replies; 6+ messages in thread
From: David S. Miller @ 2002-04-19 15:40 UTC (permalink / raw)
To: gdb-patches
This actually fixes some testsuite failures because the trap location
diddling in sparc.c:sparc_fix_call_dummy() only works if multiarch is
enabled.
I don't classify the sparc_fix_call_dummy behavior, as a bug.
Honestly there is no other way to implement that except perhaps
with a state variable, but that state variable would need to
be tied to the current task/thread/etc. and that would just be
unnecessarily complicated.
In any event, tested under sparc-linux-gnu. There are no regressions,
in fact there are quite a few less :-) Unexpected failures went from
125 (before the patch) to 112, this is using gcc-3.1 CVS.
Here is the patch:
2002-04-19 David S. Miller <davem@redhat.com>
* config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to
GDB_MULTI_ARCH_PARTIAL
* config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not
define, let tm-sp64.h do it.
--- config/sparc/tm-linux.h.~1~ Fri Apr 19 13:58:11 2002
+++ config/sparc/tm-linux.h Fri Apr 19 14:54:47 2002
@@ -23,6 +23,8 @@
#ifndef TM_SPARCLINUX_H
#define TM_SPARCLINUX_H
+#define GDB_MULTI_ARCH GDB_MULTI_ARCH_PARTIAL
+
#include "sparc/tm-sparc.h"
#undef SPARC_TARGET_LONG_DOUBLE_BYTES
--- config/sparc/tm-sp64linux.h.~1~ Fri Apr 19 13:58:03 2002
+++ config/sparc/tm-sp64linux.h Fri Apr 19 14:58:09 2002
@@ -21,8 +21,6 @@
#ifndef TM_SPARC_LIN64_H
#define TM_SPARC_LIN64_H
-#define GDB_MULTI_ARCH 0
-
#include "sparc/tm-sp64.h"
#undef SPARC_TARGET_LONG_DOUBLE_BYTES
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] Mark Sparc/Linux as multi-arch
2002-04-19 15:40 [RFA] Mark Sparc/Linux as multi-arch David S. Miller
@ 2002-04-19 16:35 ` Andrew Cagney
2002-04-20 18:51 ` David S. Miller
2002-04-19 18:32 ` Michael Snyder
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2002-04-19 16:35 UTC (permalink / raw)
To: David S. Miller; +Cc: gdb-patches
> 2002-04-19 David S. Miller <davem@redhat.com>
>
> * config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to
> GDB_MULTI_ARCH_PARTIAL
> * config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not
> define, let tm-sp64.h do it.
>
This move is definitly ok.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] Mark Sparc/Linux as multi-arch
2002-04-19 16:35 ` Andrew Cagney
@ 2002-04-20 18:51 ` David S. Miller
0 siblings, 0 replies; 6+ messages in thread
From: David S. Miller @ 2002-04-20 18:51 UTC (permalink / raw)
To: ac131313; +Cc: gdb-patches
From: Andrew Cagney <ac131313@cygnus.com>
Date: Fri, 19 Apr 2002 19:35:17 -0400
> 2002-04-19 David S. Miller <davem@redhat.com>
>
> * config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to
> GDB_MULTI_ARCH_PARTIAL
> * config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not
> define, let tm-sp64.h do it.
>
This move is definitly ok.
Installed, thanks for reviewing.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] Mark Sparc/Linux as multi-arch
2002-04-19 15:40 [RFA] Mark Sparc/Linux as multi-arch David S. Miller
2002-04-19 16:35 ` Andrew Cagney
@ 2002-04-19 18:32 ` Michael Snyder
2002-04-19 18:43 ` David S. Miller
1 sibling, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2002-04-19 18:32 UTC (permalink / raw)
To: David S. Miller; +Cc: gdb-patches
"David S. Miller" wrote:
>
> This actually fixes some testsuite failures because the trap location
> diddling in sparc.c:sparc_fix_call_dummy() only works if multiarch is
> enabled.
>
> I don't classify the sparc_fix_call_dummy behavior, as a bug.
> Honestly there is no other way to implement that except perhaps
> with a state variable, but that state variable would need to
> be tied to the current task/thread/etc. and that would just be
> unnecessarily complicated.
>
> In any event, tested under sparc-linux-gnu. There are no regressions,
> in fact there are quite a few less :-) Unexpected failures went from
> 125 (before the patch) to 112, this is using gcc-3.1 CVS.
>
> Here is the patch:
>
> 2002-04-19 David S. Miller <davem@redhat.com>
>
> * config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to
> GDB_MULTI_ARCH_PARTIAL
> * config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not
> define, let tm-sp64.h do it.
Don't you mean "let tm-linux.h do it"?
>
> --- config/sparc/tm-linux.h.~1~ Fri Apr 19 13:58:11 2002
> +++ config/sparc/tm-linux.h Fri Apr 19 14:54:47 2002
> @@ -23,6 +23,8 @@
> #ifndef TM_SPARCLINUX_H
> #define TM_SPARCLINUX_H
>
> +#define GDB_MULTI_ARCH GDB_MULTI_ARCH_PARTIAL
> +
> #include "sparc/tm-sparc.h"
>
> #undef SPARC_TARGET_LONG_DOUBLE_BYTES
> --- config/sparc/tm-sp64linux.h.~1~ Fri Apr 19 13:58:03 2002
> +++ config/sparc/tm-sp64linux.h Fri Apr 19 14:58:09 2002
> @@ -21,8 +21,6 @@
> #ifndef TM_SPARC_LIN64_H
> #define TM_SPARC_LIN64_H
>
> -#define GDB_MULTI_ARCH 0
> -
> #include "sparc/tm-sp64.h"
>
> #undef SPARC_TARGET_LONG_DOUBLE_BYTES
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] Mark Sparc/Linux as multi-arch
2002-04-19 18:32 ` Michael Snyder
@ 2002-04-19 18:43 ` David S. Miller
2002-04-19 18:50 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: David S. Miller @ 2002-04-19 18:43 UTC (permalink / raw)
To: msnyder; +Cc: gdb-patches
From: Michael Snyder <msnyder@redhat.com>
Date: Fri, 19 Apr 2002 18:21:02 -0700
"David S. Miller" wrote:
> 2002-04-19 David S. Miller <davem@redhat.com>
>
> * config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to
> GDB_MULTI_ARCH_PARTIAL
> * config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not
> define, let tm-sp64.h do it.
Don't you mean "let tm-linux.h do it"?
Nope. Not at all.
Look, tm-sp64linux.h include "config/tm-linux.h" NOT
"config/sparc/tm-linux.h"
Thus, config/sparc/tm-sp64.h defined GDB_MULTI_ARCH for us.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] Mark Sparc/Linux as multi-arch
2002-04-19 18:43 ` David S. Miller
@ 2002-04-19 18:50 ` Michael Snyder
0 siblings, 0 replies; 6+ messages in thread
From: Michael Snyder @ 2002-04-19 18:50 UTC (permalink / raw)
To: David S. Miller; +Cc: gdb-patches
"David S. Miller" wrote:
>
> From: Michael Snyder <msnyder@redhat.com>
> Date: Fri, 19 Apr 2002 18:21:02 -0700
>
> "David S. Miller" wrote:
> > 2002-04-19 David S. Miller <davem@redhat.com>
> >
> > * config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to
> > GDB_MULTI_ARCH_PARTIAL
> > * config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not
> > define, let tm-sp64.h do it.
>
> Don't you mean "let tm-linux.h do it"?
>
> Nope. Not at all.
>
> Look, tm-sp64linux.h include "config/tm-linux.h" NOT
> "config/sparc/tm-linux.h"
>
> Thus, config/sparc/tm-sp64.h defined GDB_MULTI_ARCH for us.
'K. ;-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-04-21 1:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-19 15:40 [RFA] Mark Sparc/Linux as multi-arch David S. Miller
2002-04-19 16:35 ` Andrew Cagney
2002-04-20 18:51 ` David S. Miller
2002-04-19 18:32 ` Michael Snyder
2002-04-19 18:43 ` David S. Miller
2002-04-19 18:50 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox