From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24093 invoked by alias); 20 Apr 2002 01:32:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24019 invoked from network); 20 Apr 2002 01:32:50 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 20 Apr 2002 01:32:50 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id SAA04582; Fri, 19 Apr 2002 18:32:43 -0700 (PDT) Message-ID: <3CC0C27E.229CDEC0@redhat.com> Date: Fri, 19 Apr 2002 18:32:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: "David S. Miller" CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] Mark Sparc/Linux as multi-arch References: <20020419.153127.15428651.davem@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00653.txt.bz2 "David S. Miller" wrote: > > This actually fixes some testsuite failures because the trap location > diddling in sparc.c:sparc_fix_call_dummy() only works if multiarch is > enabled. > > I don't classify the sparc_fix_call_dummy behavior, as a bug. > Honestly there is no other way to implement that except perhaps > with a state variable, but that state variable would need to > be tied to the current task/thread/etc. and that would just be > unnecessarily complicated. > > In any event, tested under sparc-linux-gnu. There are no regressions, > in fact there are quite a few less :-) Unexpected failures went from > 125 (before the patch) to 112, this is using gcc-3.1 CVS. > > Here is the patch: > > 2002-04-19 David S. Miller > > * config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to > GDB_MULTI_ARCH_PARTIAL > * config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not > define, let tm-sp64.h do it. Don't you mean "let tm-linux.h do it"? > > --- config/sparc/tm-linux.h.~1~ Fri Apr 19 13:58:11 2002 > +++ config/sparc/tm-linux.h Fri Apr 19 14:54:47 2002 > @@ -23,6 +23,8 @@ > #ifndef TM_SPARCLINUX_H > #define TM_SPARCLINUX_H > > +#define GDB_MULTI_ARCH GDB_MULTI_ARCH_PARTIAL > + > #include "sparc/tm-sparc.h" > > #undef SPARC_TARGET_LONG_DOUBLE_BYTES > --- config/sparc/tm-sp64linux.h.~1~ Fri Apr 19 13:58:03 2002 > +++ config/sparc/tm-sp64linux.h Fri Apr 19 14:58:09 2002 > @@ -21,8 +21,6 @@ > #ifndef TM_SPARC_LIN64_H > #define TM_SPARC_LIN64_H > > -#define GDB_MULTI_ARCH 0 > - > #include "sparc/tm-sp64.h" > > #undef SPARC_TARGET_LONG_DOUBLE_BYTES