Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Mark Sparc/Linux as multi-arch
Date: Fri, 19 Apr 2002 18:32:00 -0000	[thread overview]
Message-ID: <3CC0C27E.229CDEC0@redhat.com> (raw)
In-Reply-To: <20020419.153127.15428651.davem@redhat.com>

"David S. Miller" wrote:
> 
> This actually fixes some testsuite failures because the trap location
> diddling in sparc.c:sparc_fix_call_dummy() only works if multiarch is
> enabled.
> 
> I don't classify the sparc_fix_call_dummy behavior, as a bug.
> Honestly there is no other way to implement that except perhaps
> with a state variable, but that state variable would need to
> be tied to the current task/thread/etc. and that would just be
> unnecessarily complicated.
> 
> In any event, tested under sparc-linux-gnu.  There are no regressions,
> in fact there are quite a few less :-)  Unexpected failures went from
> 125 (before the patch) to 112, this is using gcc-3.1 CVS.
> 
> Here is the patch:
> 
> 2002-04-19  David S. Miller  <davem@redhat.com>
> 
>         * config/sparc/tm-linux.h (GDB_MULTI_ARCH): Define to
>         GDB_MULTI_ARCH_PARTIAL
>         * config/sparc/tm-sp64linux.h (GDB_MULTI_ARCH): Do not
>         define, let tm-sp64.h do it.

Don't you mean "let tm-linux.h do it"?

> 
> --- config/sparc/tm-linux.h.~1~ Fri Apr 19 13:58:11 2002
> +++ config/sparc/tm-linux.h     Fri Apr 19 14:54:47 2002
> @@ -23,6 +23,8 @@
>  #ifndef TM_SPARCLINUX_H
>  #define TM_SPARCLINUX_H
> 
> +#define GDB_MULTI_ARCH GDB_MULTI_ARCH_PARTIAL
> +
>  #include "sparc/tm-sparc.h"
> 
>  #undef SPARC_TARGET_LONG_DOUBLE_BYTES
> --- config/sparc/tm-sp64linux.h.~1~     Fri Apr 19 13:58:03 2002
> +++ config/sparc/tm-sp64linux.h Fri Apr 19 14:58:09 2002
> @@ -21,8 +21,6 @@
>  #ifndef TM_SPARC_LIN64_H
>  #define TM_SPARC_LIN64_H
> 
> -#define GDB_MULTI_ARCH 0
> -
>  #include "sparc/tm-sp64.h"
> 
>  #undef SPARC_TARGET_LONG_DOUBLE_BYTES


  parent reply	other threads:[~2002-04-20  1:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-19 15:40 David S. Miller
2002-04-19 16:35 ` Andrew Cagney
2002-04-20 18:51   ` David S. Miller
2002-04-19 18:32 ` Michael Snyder [this message]
2002-04-19 18:43   ` David S. Miller
2002-04-19 18:50     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CC0C27E.229CDEC0@redhat.com \
    --to=msnyder@redhat.com \
    --cc=davem@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox