Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Jeff Holcomb <jeffh@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] monitor.c fix for rom68k target boards
Date: Wed, 04 Apr 2001 13:54:00 -0000	[thread overview]
Message-ID: <3ACB89D9.A83563C8@cygnus.com> (raw)
In-Reply-To: <Pine.SOL.3.91.1010402165500.747F-100000@cse.cygnus.com>

> A possibility would be to change the test back to the original version
> rather than removing the test, like:
> 
>   if (val == 0 && valstr == p)
>      error ("monitor_supply_register (%d):  bad value from monitor: %s.",
>            regno, valstr);

Yes, that sounds better.  I think the function should still fail if it
does nothing - that would tend to suggest some sort of real problem with
the monitor.

> I'm willing to go either way, I just don't know what the intent was in
> changing the if test.

I don't think it was intentional.  Any way, assume your patch is
approved with the tweeked test.

enjoy,
	Andrew


  reply	other threads:[~2001-04-04 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-29 22:00 Jeff Holcomb
2001-03-30 12:58 ` Andrew Cagney
2001-04-02 17:13   ` Jeff Holcomb
2001-04-04 13:54     ` Andrew Cagney [this message]
2001-04-05 10:44       ` [patch] " Jeff Holcomb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ACB89D9.A83563C8@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jeffh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox