From: Jeff Holcomb <jeffh@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] monitor.c fix for rom68k target boards
Date: Thu, 29 Mar 2001 22:00:00 -0000 [thread overview]
Message-ID: <Pine.SOL.3.91.1010329214948.571m-100000@cse.cygnus.com> (raw)
This patch allows gdb to work with rom68k target boards once again (it's
been broken for a year and a half apparently).
I don't think the routine needs to care about checking for termination of
the string. In the case of this monitor, the SR is returned as
"2700-tfSm.111...xnzvc" for example. Before Jason's change to this
routine, it used strtoul which ended the matching at the first non
digit. Jason changed it to work with values larger than 'long' so it's
now a hand-coded loop to gather the digits.
2001-03-29 Jeff Holcomb <jeffh@redhat.com>
* monitor.c (monitor_supply_register): Don't check for trailing
junk since the rom68k monitor includes trailing junk in the
status register.
Index: monitor.c
===================================================================
RCS file: /cvs/src/src/gdb/monitor.c,v
retrieving revision 1.22
diff -u -p -r1.22 monitor.c
--- monitor.c 2001/03/28 21:42:31 1.22
+++ monitor.c 2001/03/30 05:51:28
@@ -906,9 +906,8 @@ monitor_supply_register (int regno, char
}
monitor_debug ("Supplying Register %d %s\n", regno, valstr);
- if (*p != '\0')
- error ("monitor_supply_register (%d): bad value from monitor: %s.",
- regno, valstr);
+ /* Don't check for trailing junk since the 68k SR includes trailing
+ junk. */
/* supply register stores in target byte order, so swap here */
--
Jeff Holcomb
jeffh@redhat.com
GDB Engineering
Red Hat, Inc.
next reply other threads:[~2001-03-29 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-29 22:00 Jeff Holcomb [this message]
2001-03-30 12:58 ` Andrew Cagney
2001-04-02 17:13 ` Jeff Holcomb
2001-04-04 13:54 ` Andrew Cagney
2001-04-05 10:44 ` [patch] " Jeff Holcomb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SOL.3.91.1010329214948.571m-100000@cse.cygnus.com \
--to=jeffh@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox