Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jeff Holcomb <jeffh@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [patch] monitor.c fix for rom68k target boards
Date: Thu, 05 Apr 2001 10:44:00 -0000	[thread overview]
Message-ID: <Pine.SOL.3.91.1010405104102.532t-100000@cse.cygnus.com> (raw)
In-Reply-To: <3ACB89D9.A83563C8@cygnus.com>

On Wed, 4 Apr 2001, Andrew Cagney wrote:

> I don't think it was intentional.  Any way, assume your patch is
> approved with the tweeked test.

Here's the patch I checked in:

2001-04-05  Jeff Holcomb  <jeffh@redhat.com>
 
        * monitor.c (monitor_supply_register): Only report an error if we
        don't get a valid value.

Index: monitor.c
===================================================================
RCS file: /cvs/src/src/gdb/monitor.c,v
retrieving revision 1.22
diff -u -p -r1.22 monitor.c
--- monitor.c   2001/03/28 21:42:31     1.22
+++ monitor.c   2001/04/05 17:42:19
@@ -906,7 +906,7 @@ monitor_supply_register (int regno, char
     }
   monitor_debug ("Supplying Register %d %s\n", regno, valstr);
 
-  if (*p != '\0')
+  if (val == 0 && valstr == p)
     error ("monitor_supply_register (%d):  bad value from monitor: %s.",
           regno, valstr);
 


      reply	other threads:[~2001-04-05 10:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-29 22:00 [RFA] " Jeff Holcomb
2001-03-30 12:58 ` Andrew Cagney
2001-04-02 17:13   ` Jeff Holcomb
2001-04-04 13:54     ` Andrew Cagney
2001-04-05 10:44       ` Jeff Holcomb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SOL.3.91.1010405104102.532t-100000@cse.cygnus.com \
    --to=jeffh@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox