From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cagney <ac131313@cygnus.com>
To: Jeff Holcomb <jeffh@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] monitor.c fix for rom68k target boards
Date: Wed, 04 Apr 2001 13:54:00 -0000
Message-id: <3ACB89D9.A83563C8@cygnus.com>
References: <Pine.SOL.3.91.1010402165500.747F-100000@cse.cygnus.com>
X-SW-Source: 2001-04/msg00036.html

> A possibility would be to change the test back to the original version
> rather than removing the test, like:
> 
>   if (val == 0 && valstr == p)
>      error ("monitor_supply_register (%d):  bad value from monitor: %s.",
>            regno, valstr);

Yes, that sounds better.  I think the function should still fail if it
does nothing - that would tend to suggest some sort of real problem with
the monitor.

> I'm willing to go either way, I just don't know what the intent was in
> changing the if test.

I don't think it was intentional.  Any way, assume your patch is
approved with the tweeked test.

enjoy,
	Andrew