Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
To: Kevin Buettner <kevinb@redhat.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] [gdb/tui] Only handle code sections in tui_find_backward_disassembly_start_address
Date: Thu, 28 Sep 2023 20:23:50 +0200	[thread overview]
Message-ID: <331a1695-74a8-411d-84c0-7de424b7b59f@suse.de> (raw)
In-Reply-To: <20230927091536.19f732ad@f37-zws-nv>

On 9/27/23 18:15, Kevin Buettner wrote:
> On Tue,  5 Sep 2023 17:03:39 +0200
> Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> wrote:
> 
>> Fix this this by limiting tui_find_backward_disassembly_start_address to
>> SEC_CODE sections.
> 
> What will happen when a user attempts to use the TUI to look at / debug
> dynamically generated code?
> 

Hi, and thanks for the review(s).

Hm, I don't know, good question.

Maybe it will be possible to detect these cases and expand the search, 
and by default do a more narrow search.

I'm not familiar with the dynamically generated code scenarios and 
support in gdb, so I'm dropping this for now.

Thanks,
- Tom

  reply	other threads:[~2023-09-28 18:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 15:03 [PATCH 1/2] [gdb/tui] Fix segfault in tui_find_disassembly_address Tom de Vries via Gdb-patches
2023-09-05 15:03 ` [PATCH 2/2] [gdb/tui] Only handle code sections in tui_find_backward_disassembly_start_address Tom de Vries via Gdb-patches
2023-09-27 16:15   ` Kevin Buettner via Gdb-patches
2023-09-28 18:23     ` Tom de Vries via Gdb-patches [this message]
2023-09-26 15:22 ` [PING][PATCH 1/2] [gdb/tui] Fix segfault in tui_find_disassembly_address Tom de Vries via Gdb-patches
2023-09-27 16:10 ` [PATCH " Kevin Buettner via Gdb-patches
2023-09-28 20:57   ` Tom de Vries via Gdb-patches
2023-09-29 10:08     ` Tom de Vries via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=331a1695-74a8-411d-84c0-7de424b7b59f@suse.de \
    --to=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox