Re: [PATCH 1/2] [gdb/tui] Fix segfault in tui_find_disassembly_address

[Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>]

On 9/27/23 18:10, Kevin Buettner wrote:
> Hi Tom,
> 
> On Tue,  5 Sep 2023 17:03:38 +0200
> Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> wrote:
> 
>> Fix the segfault by handling asm_lines.empty () results of tui_disassemble in
>> tui_find_disassembly_address.
>>
>> I've written a unit test that exercises this scenario.
>>
>> Tested on x86_64-linux.
>>
>> PR tui/30823
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30823
> 
> I don't know this area very well, but your explanation and patch look
> reasonable to me.
> 
> Reviewed-by: Kevin Buettner <kevinb@redhat.com>

Thanks for the review.

I've committed this, but I now see there's a new warning:
...
gdb/tui/tui-disasm.c: In function ‘CORE_ADDR 
tui_find_disassembly_address(gdbarch*, CORE_ADDR, int)’:
gdb/tui/tui-disasm.c:293:7: warning: ‘last_addr’ may be used 
uninitialized in this function [-Wmaybe-uninitialized]
        if (last_addr < pc)
        ^~
...

I'll take a look.

Thanks,
- Tom