From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH 1/2] [gdb/tui] Fix segfault in tui_find_disassembly_address
Date: Wed, 27 Sep 2023 09:10:13 -0700 [thread overview]
Message-ID: <20230927091013.5b3a590d@f37-zws-nv> (raw)
In-Reply-To: <20230905150339.6452-1-tdevries@suse.de>
Hi Tom,
On Tue, 5 Sep 2023 17:03:38 +0200
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> wrote:
> Fix the segfault by handling asm_lines.empty () results of tui_disassemble in
> tui_find_disassembly_address.
>
> I've written a unit test that exercises this scenario.
>
> Tested on x86_64-linux.
>
> PR tui/30823
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30823
I don't know this area very well, but your explanation and patch look
reasonable to me.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2023-09-27 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 15:03 Tom de Vries via Gdb-patches
2023-09-05 15:03 ` [PATCH 2/2] [gdb/tui] Only handle code sections in tui_find_backward_disassembly_start_address Tom de Vries via Gdb-patches
2023-09-27 16:15 ` Kevin Buettner via Gdb-patches
2023-09-28 18:23 ` Tom de Vries via Gdb-patches
2023-09-26 15:22 ` [PING][PATCH 1/2] [gdb/tui] Fix segfault in tui_find_disassembly_address Tom de Vries via Gdb-patches
2023-09-27 16:10 ` Kevin Buettner via Gdb-patches [this message]
2023-09-28 20:57 ` [PATCH " Tom de Vries via Gdb-patches
2023-09-29 10:08 ` Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927091013.5b3a590d@f37-zws-nv \
--to=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox