From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UEOXKABUFGXJgR4AWB0awg (envelope-from ) for ; Wed, 27 Sep 2023 12:10:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=HFzDssCd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 97A611E0C3; Wed, 27 Sep 2023 12:10:40 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 892891E092 for ; Wed, 27 Sep 2023 12:10:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23D3A3861853 for ; Wed, 27 Sep 2023 16:10:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23D3A3861853 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695831038; bh=aCiMH0wBkRY3Cws8BdHEmt5DP5sNNst0ALp56b/UV5M=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=HFzDssCdPyZ/AaqqeRL9cuMJpZ3L3+sVcrdRdT3g/m/cpsgU/V1jeO7ZgRsGxho1m kRaAbFfWikCFeDBCUVAx8svDNEzdkNcbs3bzQI6J47XY42ggz1SN6n2auali0hut01 ZLMEUsJLSn7nT0SodzKlrxHgOYxp7mIiXdfUBvD4= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6FC2F3857726 for ; Wed, 27 Sep 2023 16:10:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FC2F3857726 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-407-TgWTcBBuOO6arNPMuiGvFg-1; Wed, 27 Sep 2023 12:10:16 -0400 X-MC-Unique: TgWTcBBuOO6arNPMuiGvFg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B80ED101A550; Wed, 27 Sep 2023 16:10:15 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 61D17492C37; Wed, 27 Sep 2023 16:10:15 +0000 (UTC) Date: Wed, 27 Sep 2023 09:10:13 -0700 To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 1/2] [gdb/tui] Fix segfault in tui_find_disassembly_address Message-ID: <20230927091013.5b3a590d@f37-zws-nv> In-Reply-To: <20230905150339.6452-1-tdevries@suse.de> References: <20230905150339.6452-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Tom, On Tue, 5 Sep 2023 17:03:38 +0200 Tom de Vries via Gdb-patches wrote: > Fix the segfault by handling asm_lines.empty () results of tui_disassemble in > tui_find_disassembly_address. > > I've written a unit test that exercises this scenario. > > Tested on x86_64-linux. > > PR tui/30823 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30823 I don't know this area very well, but your explanation and patch look reasonable to me. Reviewed-by: Kevin Buettner