From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GDUKHMrEFWUZfR8AWB0awg (envelope-from ) for ; Thu, 28 Sep 2023 14:24:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=GDo/IpMB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 706E81E0C3; Thu, 28 Sep 2023 14:24:10 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 609061E092 for ; Thu, 28 Sep 2023 14:24:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E91A13858C52 for ; Thu, 28 Sep 2023 18:24:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E91A13858C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695925447; bh=6gaYx+TzXvcZxsjjXdzbujld1kY1m6sv566KvKrs9kc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=GDo/IpMBrQSWExcOF0VChjZilaRU5xyw477LJH0Ec/gv1HXQpGpbqaF4+xjFS+hlO sOQkw8f+bC+SL38Js1PM2LynOJvUbrAAVWJFrqECXtHiSz9s/kIEwVAaQRguEkzSqp JTM+EjptNscSIs2GsfPwkRX3M8RyhB24lWORrk8U= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 1AAC63858C52 for ; Thu, 28 Sep 2023 18:23:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AAC63858C52 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 379E71F896; Thu, 28 Sep 2023 18:23:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 21E7F138E9; Thu, 28 Sep 2023 18:23:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id L7IUB7HEFWVkfgAAMHmgww (envelope-from ); Thu, 28 Sep 2023 18:23:45 +0000 Message-ID: <331a1695-74a8-411d-84c0-7de424b7b59f@suse.de> Date: Thu, 28 Sep 2023 20:23:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/tui] Only handle code sections in tui_find_backward_disassembly_start_address Content-Language: en-US To: Kevin Buettner , Tom de Vries via Gdb-patches References: <20230905150339.6452-1-tdevries@suse.de> <20230905150339.6452-2-tdevries@suse.de> <20230927091536.19f732ad@f37-zws-nv> In-Reply-To: <20230927091536.19f732ad@f37-zws-nv> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 9/27/23 18:15, Kevin Buettner wrote: > On Tue, 5 Sep 2023 17:03:39 +0200 > Tom de Vries via Gdb-patches wrote: > >> Fix this this by limiting tui_find_backward_disassembly_start_address to >> SEC_CODE sections. > > What will happen when a user attempts to use the TUI to look at / debug > dynamically generated code? > Hi, and thanks for the review(s). Hm, I don't know, good question. Maybe it will be possible to detect these cases and expand the search, and by default do a more narrow search. I'm not familiar with the dynamically generated code scenarios and support in gdb, so I'm dropping this for now. Thanks, - Tom