[RFA] amd64-linux-tdep: use SVR4 method for skip_trampoline_code

[RFA] amd64-linux-tdep: use SVR4 method for skip_trampoline_code

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

Hi Folks,

This small change is required for reverse-step/next on amd64 linux,
and causes no regressions in the testsuite.

OK to check in?
Michael


[-- Attachment #2: amd64-1.txt --]
[-- Type: text/plain, Size: 947 bytes --]

2009-08-16  Michael Snyder  <msnyder@vmware.com>

	* amd64-linux-tdep.c (amd64_linux_init_abi): Set gdbarch to use
	SVR4 method for skip_trampoline_code.

Index: amd64-linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-linux-tdep.c,v
retrieving revision 1.26
diff -u -p -r1.26 amd64-linux-tdep.c
--- amd64-linux-tdep.c	10 Aug 2009 03:06:34 -0000	1.26
+++ amd64-linux-tdep.c	16 Aug 2009 22:52:32 -0000
@@ -1415,6 +1415,9 @@ amd64_linux_init_abi (struct gdbarch_inf
   set_gdbarch_fetch_tls_load_module_address (gdbarch,
                                              svr4_fetch_objfile_link_map);
 
+  /* GNU/Linux uses SVR4-style shared libraries.  */
+  set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
+
   /* Displaced stepping.  */
   set_gdbarch_displaced_step_copy_insn (gdbarch,
                                         amd64_displaced_step_copy_insn);

Re: [RFA] amd64-linux-tdep: use SVR4 method for skip_trampoline_code

[Mark Kettenis]

>  Hi Folks,
>
>  This small change is required for reverse-step/next on amd64 linux,
>  and causes no regressions in the testsuite.
>
>  OK to check in?

Fine with me as well.

Re: [RFA] amd64-linux-tdep: use SVR4 method for skip_trampoline_code

[Hui Zhu]

Same with amd64-2.txt.  Work with reverse testsuite very well.

Thanks,
Hui

On Mon, Aug 17, 2009 at 06:54, Michael Snyder<msnyder@vmware.com> wrote:
> Hi Folks,
>
> This small change is required for reverse-step/next on amd64 linux,
> and causes no regressions in the testsuite.
>
> OK to check in?
> Michael
>
>
> 2009-08-16  Michael Snyder  <msnyder@vmware.com>
>
>        * amd64-linux-tdep.c (amd64_linux_init_abi): Set gdbarch to use
>        SVR4 method for skip_trampoline_code.
>
> Index: amd64-linux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/amd64-linux-tdep.c,v
> retrieving revision 1.26
> diff -u -p -r1.26 amd64-linux-tdep.c
> --- amd64-linux-tdep.c  10 Aug 2009 03:06:34 -0000      1.26
> +++ amd64-linux-tdep.c  16 Aug 2009 22:52:32 -0000
> @@ -1415,6 +1415,9 @@ amd64_linux_init_abi (struct gdbarch_inf
>   set_gdbarch_fetch_tls_load_module_address (gdbarch,
>                                              svr4_fetch_objfile_link_map);
>
> +  /* GNU/Linux uses SVR4-style shared libraries.  */
> +  set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
> +
>   /* Displaced stepping.  */
>   set_gdbarch_displaced_step_copy_insn (gdbarch,
>                                         amd64_displaced_step_copy_insn);
>
>

Re: [RFA] amd64-linux-tdep: use SVR4 method for skip_trampoline_code

[Michael Snyder]

Mark Kettenis wrote:
>>  Hi Folks,
>>
>>  This small change is required for reverse-step/next on amd64 linux,
>>  and causes no regressions in the testsuite.
>>
>>  OK to check in?
> 
> Fine with me as well.

Thanks Mark.  Committed.
And welcome back!  ;-)