From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66039-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27116 invoked by alias); 17 Aug 2009 14:45:26 -0000
Received: (qmail 27104 invoked by uid 22791); 17 Aug 2009 14:45:25 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from wf-out-1314.google.com (HELO wf-out-1314.google.com) (209.85.200.173)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Aug 2009 14:45:20 +0000
Received: by wf-out-1314.google.com with SMTP id 23so840564wfg.24         for <gdb-patches@sourceware.org>; Mon, 17 Aug 2009 07:45:17 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.5.39 with SMTP id 39mr680743wfe.81.1250520317062; Mon, 17  	Aug 2009 07:45:17 -0700 (PDT)
In-Reply-To: <4A888E2B.1030601@vmware.com>
References: <4A888E2B.1030601@vmware.com>
From: Hui Zhu <teawater@gmail.com>
Date: Mon, 17 Aug 2009 15:29:00 -0000
Message-ID: <daef60380908170744l187ffbcdk2da724971085babc@mail.gmail.com>
Subject: Re: [RFA] amd64-linux-tdep: use SVR4 method for skip_trampoline_code
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00238.txt.bz2

Same with amd64-2.txt.  Work with reverse testsuite very well.

Thanks,
Hui

On Mon, Aug 17, 2009 at 06:54, Michael Snyder<msnyder@vmware.com> wrote:
> Hi Folks,
>
> This small change is required for reverse-step/next on amd64 linux,
> and causes no regressions in the testsuite.
>
> OK to check in?
> Michael
>
>
> 2009-08-16 =A0Michael Snyder =A0<msnyder@vmware.com>
>
> =A0 =A0 =A0 =A0* amd64-linux-tdep.c (amd64_linux_init_abi): Set gdbarch t=
o use
> =A0 =A0 =A0 =A0SVR4 method for skip_trampoline_code.
>
> Index: amd64-linux-tdep.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/gdb/amd64-linux-tdep.c,v
> retrieving revision 1.26
> diff -u -p -r1.26 amd64-linux-tdep.c
> --- amd64-linux-tdep.c =A010 Aug 2009 03:06:34 -0000 =A0 =A0 =A01.26
> +++ amd64-linux-tdep.c =A016 Aug 2009 22:52:32 -0000
> @@ -1415,6 +1415,9 @@ amd64_linux_init_abi (struct gdbarch_inf
> =A0 set_gdbarch_fetch_tls_load_module_address (gdbarch,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0svr4_fetch_objfile_link_map);
>
> + =A0/* GNU/Linux uses SVR4-style shared libraries. =A0*/
> + =A0set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_tar=
get);
> +
> =A0 /* Displaced stepping. =A0*/
> =A0 set_gdbarch_displaced_step_copy_insn (gdbarch,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 amd64_displaced_step_copy_insn);
>
>