Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] amd64-linux-tdep: use SVR4 method for skip_trampoline_code
Date: Mon, 17 Aug 2009 15:29:00 -0000	[thread overview]
Message-ID: <daef60380908170744l187ffbcdk2da724971085babc@mail.gmail.com> (raw)
In-Reply-To: <4A888E2B.1030601@vmware.com>

Same with amd64-2.txt.  Work with reverse testsuite very well.

Thanks,
Hui

On Mon, Aug 17, 2009 at 06:54, Michael Snyder<msnyder@vmware.com> wrote:
> Hi Folks,
>
> This small change is required for reverse-step/next on amd64 linux,
> and causes no regressions in the testsuite.
>
> OK to check in?
> Michael
>
>
> 2009-08-16  Michael Snyder  <msnyder@vmware.com>
>
>        * amd64-linux-tdep.c (amd64_linux_init_abi): Set gdbarch to use
>        SVR4 method for skip_trampoline_code.
>
> Index: amd64-linux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/amd64-linux-tdep.c,v
> retrieving revision 1.26
> diff -u -p -r1.26 amd64-linux-tdep.c
> --- amd64-linux-tdep.c  10 Aug 2009 03:06:34 -0000      1.26
> +++ amd64-linux-tdep.c  16 Aug 2009 22:52:32 -0000
> @@ -1415,6 +1415,9 @@ amd64_linux_init_abi (struct gdbarch_inf
>   set_gdbarch_fetch_tls_load_module_address (gdbarch,
>                                              svr4_fetch_objfile_link_map);
>
> +  /* GNU/Linux uses SVR4-style shared libraries.  */
> +  set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
> +
>   /* Displaced stepping.  */
>   set_gdbarch_displaced_step_copy_insn (gdbarch,
>                                         amd64_displaced_step_copy_insn);
>
>


      parent reply	other threads:[~2009-08-17 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17  0:22 Michael Snyder
2009-08-17 14:21 ` Mark Kettenis
2009-08-17 18:24   ` Michael Snyder
2009-08-17 15:29 ` Hui Zhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380908170744l187ffbcdk2da724971085babc@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox