Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Hayward <Alan.Hayward@arm.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp
Date: Fri, 19 Oct 2018 16:03:00 -0000	[thread overview]
Message-ID: <3027DC3C-0892-4252-A2E9-BE0F0472594A@arm.com> (raw)
In-Reply-To: <1bfe2f94-d708-7795-f166-581de1c471f5@redhat.com>



> On 19 Oct 2018, at 16:42, Pedro Alves <palves@redhat.com> wrote:
> 
> On 10/19/2018 04:21 PM, Alan Hayward wrote:
>> 
>>> On 19 Oct 2018, at 15:17, Pedro Alves <palves@redhat.com> wrote:
>>> 
>>> On 10/19/2018 11:12 AM, Alan Hayward wrote:
>>>> Fix the layout used in the regexp for breakpoints.
>>>> 
>>>> Fixes two FAILS.
>>>> 
>>> 
>>> Curious, it doesn't fail for me.  What changed?
>> 
>> Two things:
>> 
>> Info breakpoint - the gaps between the fields. Some parts of the regexp
>> was just checking for 5 spaces, some parts were checking spaces+tabs.
>> It was also inconsistent throughout the .exp file - the exact same gaps
>> are checked differently. Made sure they were all spaces+tab checks.
> 
> OK.
> 
>> On both x86 and aarch64, for the breakpoint at main, I get line 48 - the
>> “{“, instead of line 49, the first actual line of code. Allowed it to
>> have either. Maybe better fix would be to lookup the line number.
> 
> It's rare to see that these days, especially at -O0.
> That might be some regression.  What compiler was that?
> 

Would that be a bug in GDB or the compiler?

My setups are:

Aarch64 Ubuntu 16.04:
gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

X86 Ubuntu 16.04:
gcc (Ubuntu 7.2.0-1ubuntu1~16.04) 7.2.0


I just tried it without my patch on 

Aarch64 Opensuse13.3 with
gcc (SUSE Linux) 7.2.1 20171020 [gcc-7-branch revision 253932]

Aarch64 centos7.4 with
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)

It passes on both of those. Looks like it could be an Ubuntu
issue then?


Alan.


      parent reply	other threads:[~2018-10-19 16:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 10:13 Alan Hayward
2018-10-19 14:17 ` Pedro Alves
2018-10-19 15:21   ` Alan Hayward
     [not found]     ` <1bfe2f94-d708-7795-f166-581de1c471f5@redhat.com>
2018-10-19 16:03       ` Alan Hayward [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3027DC3C-0892-4252-A2E9-BE0F0472594A@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox