Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp

Alan Hayward
2018-10-19T15:21:13Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 825 bytes --]

> On 19 Oct 2018, at 15:17, Pedro Alves <palves@redhat.com> wrote:
>
> On 10/19/2018 11:12 AM, Alan Hayward wrote:
>> Fix the layout used in the regexp for breakpoints.
>>
>> Fixes two FAILS.
>>
>
> Curious, it doesn't fail for me. What changed?

Two things:

Info breakpoint - the gaps between the fields. Some parts of the regexp
was just checking for 5 spaces, some parts were checking spaces+tabs.
It was also inconsistent throughout the .exp file - the exact same gaps
are checked differently. Made sure they were all spaces+tab checks.

On both x86 and aarch64, for the breakpoint at main, I get line 48 - the
“{“, instead of line 49, the first actual line of code. Allowed it to
have either. Maybe better fix would be to lookup the line number.

Alan.\x16º&Öéj×!zÊÞ¶êç×{×™b²Ö«r\x18\x1dn–­r\x17¬