From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63203 invoked by alias); 19 Oct 2018 16:03:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63153 invoked by uid 89); 19 Oct 2018 16:03:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=16.04, 1604 X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40044.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Oct 2018 16:03:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAzBxZY9qKCch9ixAadVgnd+U1HsXP2i84N6EuMOnbw=; b=r8nb+GLgaOaUaCzoHuaNIUvaEGFjecKmfRz5CX4qXc3Sa7eD2X52ZcQBO5MVdlJqVlKG1iTv0HtQY9mI755pzAB22IVYZV/q2VMaZuzfJYUcciLWMJ1IkrBswIdGAlrPVHNMG9hfvfNT3Ph0FlVqCyEOaao5m5beLfg+Nda7WsU= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2424.eurprd08.prod.outlook.com (10.172.251.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Fri, 19 Oct 2018 16:03:49 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11%6]) with mapi id 15.20.1228.033; Fri, 19 Oct 2018 16:03:49 +0000 From: Alan Hayward To: Pedro Alves CC: GDB Patches , nd Subject: Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp Date: Fri, 19 Oct 2018 16:03:00 -0000 Message-ID: <3027DC3C-0892-4252-A2E9-BE0F0472594A@arm.com> References: <20181019101257.31068-1-alan.hayward@arm.com> <6c631022-255a-84da-deee-ee77eaf689f5@redhat.com> <1bfe2f94-d708-7795-f166-581de1c471f5@redhat.com> In-Reply-To: <1bfe2f94-d708-7795-f166-581de1c471f5@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <166405EFF10C3144A2286946995FBA96@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00434.txt.bz2 DQoNCj4gT24gMTkgT2N0IDIwMTgsIGF0IDE2OjQyLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMTAvMTkvMjAx OCAwNDoyMSBQTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gDQo+Pj4gT24g MTkgT2N0IDIwMTgsIGF0IDE1OjE3LCBQZWRybyBBbHZlcyA8cGFsdmVzQHJl ZGhhdC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IE9uIDEwLzE5LzIwMTggMTE6 MTIgQU0sIEFsYW4gSGF5d2FyZCB3cm90ZToNCj4+Pj4gRml4IHRoZSBsYXlv dXQgdXNlZCBpbiB0aGUgcmVnZXhwIGZvciBicmVha3BvaW50cy4NCj4+Pj4g DQo+Pj4+IEZpeGVzIHR3byBGQUlMUy4NCj4+Pj4gDQo+Pj4gDQo+Pj4gQ3Vy aW91cywgaXQgZG9lc24ndCBmYWlsIGZvciBtZS4gIFdoYXQgY2hhbmdlZD8N Cj4+IA0KPj4gVHdvIHRoaW5nczoNCj4+IA0KPj4gSW5mbyBicmVha3BvaW50 IC0gdGhlIGdhcHMgYmV0d2VlbiB0aGUgZmllbGRzLiBTb21lIHBhcnRzIG9m IHRoZSByZWdleHANCj4+IHdhcyBqdXN0IGNoZWNraW5nIGZvciA1IHNwYWNl cywgc29tZSBwYXJ0cyB3ZXJlIGNoZWNraW5nIHNwYWNlcyt0YWJzLg0KPj4g SXQgd2FzIGFsc28gaW5jb25zaXN0ZW50IHRocm91Z2hvdXQgdGhlIC5leHAg ZmlsZSAtIHRoZSBleGFjdCBzYW1lIGdhcHMNCj4+IGFyZSBjaGVja2VkIGRp ZmZlcmVudGx5LiBNYWRlIHN1cmUgdGhleSB3ZXJlIGFsbCBzcGFjZXMrdGFi IGNoZWNrcy4NCj4gDQo+IE9LLg0KPiANCj4+IE9uIGJvdGggeDg2IGFuZCBh YXJjaDY0LCBmb3IgdGhlIGJyZWFrcG9pbnQgYXQgbWFpbiwgSSBnZXQgbGlu ZSA0OCAtIHRoZQ0KPj4g4oCce+KAnCwgaW5zdGVhZCBvZiBsaW5lIDQ5LCB0 aGUgZmlyc3QgYWN0dWFsIGxpbmUgb2YgY29kZS4gQWxsb3dlZCBpdCB0bw0K Pj4gaGF2ZSBlaXRoZXIuIE1heWJlIGJldHRlciBmaXggd291bGQgYmUgdG8g bG9va3VwIHRoZSBsaW5lIG51bWJlci4NCj4gDQo+IEl0J3MgcmFyZSB0byBz ZWUgdGhhdCB0aGVzZSBkYXlzLCBlc3BlY2lhbGx5IGF0IC1PMC4NCj4gVGhh dCBtaWdodCBiZSBzb21lIHJlZ3Jlc3Npb24uICBXaGF0IGNvbXBpbGVyIHdh cyB0aGF0Pw0KPiANCg0KV291bGQgdGhhdCBiZSBhIGJ1ZyBpbiBHREIgb3Ig dGhlIGNvbXBpbGVyPw0KDQpNeSBzZXR1cHMgYXJlOg0KDQpBYXJjaDY0IFVi dW50dSAxNi4wNDoNCmdjYyAoVWJ1bnR1L0xpbmFybyA1LjQuMC02dWJ1bnR1 MX4xNi4wNC40KSA1LjQuMCAyMDE2MDYwOQ0KDQpYODYgVWJ1bnR1IDE2LjA0 Og0KZ2NjIChVYnVudHUgNy4yLjAtMXVidW50dTF+MTYuMDQpIDcuMi4wDQoN Cg0KSSBqdXN0IHRyaWVkIGl0IHdpdGhvdXQgbXkgcGF0Y2ggb24gDQoNCkFh cmNoNjQgT3BlbnN1c2UxMy4zIHdpdGgNCmdjYyAoU1VTRSBMaW51eCkgNy4y LjEgMjAxNzEwMjAgW2djYy03LWJyYW5jaCByZXZpc2lvbiAyNTM5MzJdDQoN CkFhcmNoNjQgY2VudG9zNy40IHdpdGgNCmdjYyAoR0NDKSA0LjguNSAyMDE1 MDYyMyAoUmVkIEhhdCA0LjguNS0xNikNCg0KSXQgcGFzc2VzIG9uIGJvdGgg b2YgdGhvc2UuIExvb2tzIGxpa2UgaXQgY291bGQgYmUgYW4gVWJ1bnR1DQpp c3N1ZSB0aGVuPw0KDQoNCkFsYW4uDQoNCg== >From gdb-patches-return-151717-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Oct 19 17:40:21 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 21414 invoked by alias); 19 Oct 2018 17:40:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21387 invoked by uid 89); 19 Oct 2018 17:40:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Oct 2018 17:40:18 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6E84804E2; Fri, 19 Oct 2018 17:40:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0267B694CD; Fri, 19 Oct 2018 17:40:15 +0000 (UTC) Subject: Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp To: Alan Hayward References: <20181019101257.31068-1-alan.hayward@arm.com> <6c631022-255a-84da-deee-ee77eaf689f5@redhat.com> <1bfe2f94-d708-7795-f166-581de1c471f5@redhat.com> <3027DC3C-0892-4252-A2E9-BE0F0472594A@arm.com> Cc: GDB Patches , nd From: Pedro Alves Message-ID: <5eed9ad1-0e7c-a35d-58c5-d9774b981b4c@redhat.com> Date: Fri, 19 Oct 2018 17:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3027DC3C-0892-4252-A2E9-BE0F0472594A@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-10/txt/msg00435.txt.bz2 Content-length: 1911 On 10/19/2018 05:03 PM, Alan Hayward wrote: > > >> On 19 Oct 2018, at 16:42, Pedro Alves wrote: >> >> On 10/19/2018 04:21 PM, Alan Hayward wrote: >>> >>>> On 19 Oct 2018, at 15:17, Pedro Alves wrote: >>>> >>>> On 10/19/2018 11:12 AM, Alan Hayward wrote: >>>>> Fix the layout used in the regexp for breakpoints. >>>>> >>>>> Fixes two FAILS. >>>>> >>>> >>>> Curious, it doesn't fail for me. What changed? >>> >>> Two things: >>> >>> Info breakpoint - the gaps between the fields. Some parts of the regexp >>> was just checking for 5 spaces, some parts were checking spaces+tabs. >>> It was also inconsistent throughout the .exp file - the exact same gaps >>> are checked differently. Made sure they were all spaces+tab checks. >> >> OK. >> >>> On both x86 and aarch64, for the breakpoint at main, I get line 48 - the >>> “{“, instead of line 49, the first actual line of code. Allowed it to >>> have either. Maybe better fix would be to lookup the line number. >> >> It's rare to see that these days, especially at -O0. >> That might be some regression. What compiler was that? >> > > Would that be a bug in GDB or the compiler? Impossible to say off hand. Could be either. > > My setups are: > > Aarch64 Ubuntu 16.04: > gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 > > X86 Ubuntu 16.04: > gcc (Ubuntu 7.2.0-1ubuntu1~16.04) 7.2.0 > > > I just tried it without my patch on > > Aarch64 Opensuse13.3 with > gcc (SUSE Linux) 7.2.1 20171020 [gcc-7-branch revision 253932] > > Aarch64 centos7.4 with > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16) > > It passes on both of those. Looks like it could be an Ubuntu > issue then? Ubuntu's gcc has some local changes, and enables some gcc options by default that aren't enabled elsewhere. So it could also be that GDB is mishandling something that isn't well tested elsewhere. Thanks, Pedro Alves