Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Hayward <Alan.Hayward@arm.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp
Date: Fri, 19 Oct 2018 15:21:00 -0000	[thread overview]
Message-ID: <CA9B81AA-D129-457D-AA47-20A435C9A525@arm.com> (raw)
In-Reply-To: <6c631022-255a-84da-deee-ee77eaf689f5@redhat.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 825 bytes --]


> On 19 Oct 2018, at 15:17, Pedro Alves <palves@redhat.com> wrote:
> 
> On 10/19/2018 11:12 AM, Alan Hayward wrote:
>> Fix the layout used in the regexp for breakpoints.
>> 
>> Fixes two FAILS.
>> 
> 
> Curious, it doesn't fail for me.  What changed?

Two things:

Info breakpoint - the gaps between the fields. Some parts of the regexp
was just checking for 5 spaces, some parts were checking spaces+tabs.
It was also inconsistent throughout the .exp file - the exact same gaps
are checked differently. Made sure they were all spaces+tab checks.

On both x86 and aarch64, for the breakpoint at main, I get line 48 - the
“{“, instead of line 49, the first actual line of code. Allowed it to
have either. Maybe better fix would be to lookup the line number.


Alan.\x16º&Öéj×!zÊÞ¶êçם{×™b²Ö«r\x18\x1dn–­r\x17¬

  reply	other threads:[~2018-10-19 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 10:13 Alan Hayward
2018-10-19 14:17 ` Pedro Alves
2018-10-19 15:21   ` Alan Hayward [this message]
     [not found]     ` <1bfe2f94-d708-7795-f166-581de1c471f5@redhat.com>
2018-10-19 16:03       ` Alan Hayward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA9B81AA-D129-457D-AA47-20A435C9A525@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox