From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15580 invoked by alias); 19 Oct 2018 15:21:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14282 invoked by uid 89); 19 Oct 2018 15:21:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:824, HAccept-Language:en-GB X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00083.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Oct 2018 15:21:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOHdNxQAH+hDKILHSnxziYwACUJBe4/3MX1pKoFx6iU=; b=GJbc7t5uwbmonFqrR2Vmkab3LIDv3WqbkIi3gTxei+NBB7XjqHly7Wp9eFpYFBaAK8t1KVAq8+MFJhoWzpUqUegkSv7iE+a3yQSOP+abYhBAo4jbSzNOeUfIo4UHYTXxO39//LYA76PjI2Q67EBqUiR9wUyw1g+JvSBUl0CLTYo= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2230.eurprd08.prod.outlook.com (10.172.227.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Fri, 19 Oct 2018 15:21:07 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11%6]) with mapi id 15.20.1228.033; Fri, 19 Oct 2018 15:21:06 +0000 From: Alan Hayward To: Pedro Alves CC: GDB Patches , nd Subject: Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp Date: Fri, 19 Oct 2018 15:21:00 -0000 Message-ID: References: <20181019101257.31068-1-alan.hayward@arm.com> <6c631022-255a-84da-deee-ee77eaf689f5@redhat.com> In-Reply-To: <6c631022-255a-84da-deee-ee77eaf689f5@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <4378258F44178044BB1D367DA73455F4@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00432.txt.bz2 DQo+IE9uIDE5IE9jdCAyMDE4LCBhdCAxNToxNywgUGVkcm8gQWx2ZXMgPHBh bHZlc0ByZWRoYXQuY29tPiB3cm90ZToNCj4gDQo+IE9uIDEwLzE5LzIwMTgg MTE6MTIgQU0sIEFsYW4gSGF5d2FyZCB3cm90ZToNCj4+IEZpeCB0aGUgbGF5 b3V0IHVzZWQgaW4gdGhlIHJlZ2V4cCBmb3IgYnJlYWtwb2ludHMuDQo+PiAN Cj4+IEZpeGVzIHR3byBGQUlMUy4NCj4+IA0KPiANCj4gQ3VyaW91cywgaXQg ZG9lc24ndCBmYWlsIGZvciBtZS4gIFdoYXQgY2hhbmdlZD8NCg0KVHdvIHRo aW5nczoNCg0KSW5mbyBicmVha3BvaW50IC0gdGhlIGdhcHMgYmV0d2VlbiB0 aGUgZmllbGRzLiBTb21lIHBhcnRzIG9mIHRoZSByZWdleHANCndhcyBqdXN0 IGNoZWNraW5nIGZvciA1IHNwYWNlcywgc29tZSBwYXJ0cyB3ZXJlIGNoZWNr aW5nIHNwYWNlcyt0YWJzLg0KSXQgd2FzIGFsc28gaW5jb25zaXN0ZW50IHRo cm91Z2hvdXQgdGhlIC5leHAgZmlsZSAtIHRoZSBleGFjdCBzYW1lIGdhcHMN CmFyZSBjaGVja2VkIGRpZmZlcmVudGx5LiBNYWRlIHN1cmUgdGhleSB3ZXJl IGFsbCBzcGFjZXMrdGFiIGNoZWNrcy4NCg0KT24gYm90aCB4ODYgYW5kIGFh cmNoNjQsIGZvciB0aGUgYnJlYWtwb2ludCBhdCBtYWluLCBJIGdldCBsaW5l IDQ4IC0gdGhlDQrigJx74oCcLCBpbnN0ZWFkIG9mIGxpbmUgNDksIHRoZSBm aXJzdCBhY3R1YWwgbGluZSBvZiBjb2RlLiBBbGxvd2VkIGl0IHRvDQpoYXZl IGVpdGhlci4gTWF5YmUgYmV0dGVyIGZpeCB3b3VsZCBiZSB0byBsb29rdXAg dGhlIGxpbmUgbnVtYmVyLg0KDQoNCkFsYW4u >From gdb-patches-return-151715-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Oct 19 15:42:27 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 26689 invoked by alias); 19 Oct 2018 15:42:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26656 invoked by uid 89); 19 Oct 2018 15:42:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1026, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Oct 2018 15:42:23 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB499637FE; Fri, 19 Oct 2018 15:42:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 239E3600C0; Fri, 19 Oct 2018 15:42:20 +0000 (UTC) Subject: Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp To: Alan Hayward References: <20181019101257.31068-1-alan.hayward@arm.com> <6c631022-255a-84da-deee-ee77eaf689f5@redhat.com> Cc: GDB Patches , nd From: Pedro Alves Message-ID: <1bfe2f94-d708-7795-f166-581de1c471f5@redhat.com> Date: Fri, 19 Oct 2018 15:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-10/txt/msg00433.txt.bz2 Content-length: 970 On 10/19/2018 04:21 PM, Alan Hayward wrote: > >> On 19 Oct 2018, at 15:17, Pedro Alves wrote: >> >> On 10/19/2018 11:12 AM, Alan Hayward wrote: >>> Fix the layout used in the regexp for breakpoints. >>> >>> Fixes two FAILS. >>> >> >> Curious, it doesn't fail for me. What changed? > > Two things: > > Info breakpoint - the gaps between the fields. Some parts of the regexp > was just checking for 5 spaces, some parts were checking spaces+tabs. > It was also inconsistent throughout the .exp file - the exact same gaps > are checked differently. Made sure they were all spaces+tab checks. OK. > On both x86 and aarch64, for the breakpoint at main, I get line 48 - the > “{“, instead of line 49, the first actual line of code. Allowed it to > have either. Maybe better fix would be to lookup the line number. It's rare to see that these days, especially at -O0. That might be some regression. What compiler was that? Thanks, Pedro Alves