From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches
Date: Mon, 21 May 2018 00:09:00 -0000 [thread overview]
Message-ID: <2feaaf4a-bace-42b0-e97c-3c68563040ef@simark.ca> (raw)
In-Reply-To: <20180519160606.19969-3-tom@tromey.com>
On 2018-05-19 12:06 PM, Tom Tromey wrote:
> ada_collect_symbol_completion_matches installs a null_cleanup but not
> any other cleanups. This patch removes it.
It doesn't seem like any of the called function leaves a dangling cleanup, so LGTM.
Simon
next prev parent reply other threads:[~2018-05-20 23:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 20:37 [RFA 0/3] More Ada cleanup removal Tom Tromey
2018-05-19 16:06 ` [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches Tom Tromey
2018-05-21 0:09 ` Simon Marchi [this message]
2018-05-19 16:06 ` [RFA 3/3] Change ada_catchpoint::excep_string to be a std::string Tom Tromey
2018-05-21 1:12 ` Simon Marchi
2018-05-22 14:49 ` [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning Joel Brobecker
2018-05-22 14:50 ` [pushed/Ada] fix "stale cleanup" internal-warning when using "catch assert" command Joel Brobecker
2018-05-22 14:58 ` [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning Tom Tromey
2018-05-22 15:48 ` Joel Brobecker
2018-05-19 20:37 ` [RFA 1/3] Remove cleanup from ada-lang.c Tom Tromey
2018-05-21 0:06 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2feaaf4a-bace-42b0-e97c-3c68563040ef@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox