From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57979 invoked by alias); 20 May 2018 23:59:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57969 invoked by uid 89); 20 May 2018 23:59:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 May 2018 23:59:10 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D1D161E4F7; Sun, 20 May 2018 19:59:08 -0400 (EDT) Subject: Re: [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches To: Tom Tromey , gdb-patches@sourceware.org References: <20180519160606.19969-1-tom@tromey.com> <20180519160606.19969-3-tom@tromey.com> From: Simon Marchi Message-ID: <2feaaf4a-bace-42b0-e97c-3c68563040ef@simark.ca> Date: Mon, 21 May 2018 00:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180519160606.19969-3-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00451.txt.bz2 On 2018-05-19 12:06 PM, Tom Tromey wrote: > ada_collect_symbol_completion_matches installs a null_cleanup but not > any other cleanups. This patch removes it. It doesn't seem like any of the called function leaves a dangling cleanup, so LGTM. Simon