From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning
Date: Tue, 22 May 2018 14:49:00 -0000 [thread overview]
Message-ID: <1526999977-126638-1-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <f9d45c1b-4738-2220-6690-8b80ae10da98@simark.ca>
Hello,
There was a small bug in Tom's patch that caused the execution
of the "catch assert" command to throw a C++ exception. I have
pushed the following patch to master as an obvious fix to the
immediate issue:
[] fix "stale cleanup" internal-warning when using "catch assert"
But at the same time, this leads me to believe we may have a weakness
top.c::execute_command, which installs a cleanup, and "forgets" to
discard it when C++ exceptions are raised.
But maybe that's just the way it is, and we just want to make sure
we never let C+ exceptions get away from us? Thoughts on that?
Anyways, for now, the immediate issue is fixed.
--
Joel
next prev parent reply other threads:[~2018-05-22 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 20:37 [RFA 0/3] More Ada cleanup removal Tom Tromey
2018-05-19 16:06 ` [RFA 3/3] Change ada_catchpoint::excep_string to be a std::string Tom Tromey
2018-05-21 1:12 ` Simon Marchi
2018-05-22 14:49 ` Joel Brobecker [this message]
2018-05-22 14:50 ` [pushed/Ada] fix "stale cleanup" internal-warning when using "catch assert" command Joel Brobecker
2018-05-22 14:58 ` [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning Tom Tromey
2018-05-22 15:48 ` Joel Brobecker
2018-05-19 16:06 ` [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches Tom Tromey
2018-05-21 0:09 ` Simon Marchi
2018-05-19 20:37 ` [RFA 1/3] Remove cleanup from ada-lang.c Tom Tromey
2018-05-21 0:06 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526999977-126638-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox