From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches
Date: Sat, 19 May 2018 16:06:00 -0000 [thread overview]
Message-ID: <20180519160606.19969-3-tom@tromey.com> (raw)
In-Reply-To: <20180519160606.19969-1-tom@tromey.com>
ada_collect_symbol_completion_matches installs a null_cleanup but not
any other cleanups. This patch removes it.
gdb/ChangeLog
2018-05-18 Tom Tromey <tom@tromey.com>
* ada-lang.c (ada_collect_symbol_completion_matches): Remove
cleanup.
---
gdb/ChangeLog | 5 +++++
gdb/ada-lang.c | 3 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index da5f75030c..cbb0fe9d82 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -6445,7 +6445,6 @@ ada_collect_symbol_completion_matches (completion_tracker &tracker,
struct objfile *objfile;
const struct block *b, *surrounding_static_block = 0;
struct block_iterator iter;
- struct cleanup *old_chain = make_cleanup (null_cleanup, NULL);
gdb_assert (code == TYPE_CODE_UNDEF);
@@ -6550,8 +6549,6 @@ ada_collect_symbol_completion_matches (completion_tracker &tracker,
lookup_name, text, word);
}
}
-
- do_cleanups (old_chain);
}
/* Field Access */
--
2.13.6
next prev parent reply other threads:[~2018-05-19 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 20:37 [RFA 0/3] More Ada cleanup removal Tom Tromey
2018-05-19 16:06 ` [RFA 3/3] Change ada_catchpoint::excep_string to be a std::string Tom Tromey
2018-05-21 1:12 ` Simon Marchi
2018-05-22 14:49 ` [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning Joel Brobecker
2018-05-22 14:50 ` [pushed/Ada] fix "stale cleanup" internal-warning when using "catch assert" command Joel Brobecker
2018-05-22 14:58 ` [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning Tom Tromey
2018-05-22 15:48 ` Joel Brobecker
2018-05-19 16:06 ` Tom Tromey [this message]
2018-05-21 0:09 ` [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches Simon Marchi
2018-05-19 20:37 ` [RFA 1/3] Remove cleanup from ada-lang.c Tom Tromey
2018-05-21 0:06 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519160606.19969-3-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox