From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59806 invoked by alias); 19 May 2018 16:06:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59755 invoked by uid 89); 19 May 2018 16:06:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Field X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 May 2018 16:06:11 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 149E01738FC for ; Sat, 19 May 2018 11:06:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id K4N0fDQO1y2aLK4N0fUwW9; Sat, 19 May 2018 11:06:10 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:37004 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fK4Mz-002Uoe-R2; Sat, 19 May 2018 11:06:09 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches Date: Sat, 19 May 2018 16:06:00 -0000 Message-Id: <20180519160606.19969-3-tom@tromey.com> In-Reply-To: <20180519160606.19969-1-tom@tromey.com> References: <20180519160606.19969-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fK4Mz-002Uoe-R2 X-Source-Sender: 174-29-44-154.hlrn.qwest.net (bapiya.Home) [174.29.44.154]:37004 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00439.txt.bz2 ada_collect_symbol_completion_matches installs a null_cleanup but not any other cleanups. This patch removes it. gdb/ChangeLog 2018-05-18 Tom Tromey * ada-lang.c (ada_collect_symbol_completion_matches): Remove cleanup. --- gdb/ChangeLog | 5 +++++ gdb/ada-lang.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index da5f75030c..cbb0fe9d82 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -6445,7 +6445,6 @@ ada_collect_symbol_completion_matches (completion_tracker &tracker, struct objfile *objfile; const struct block *b, *surrounding_static_block = 0; struct block_iterator iter; - struct cleanup *old_chain = make_cleanup (null_cleanup, NULL); gdb_assert (code == TYPE_CODE_UNDEF); @@ -6550,8 +6549,6 @@ ada_collect_symbol_completion_matches (completion_tracker &tracker, lookup_name, text, word); } } - - do_cleanups (old_chain); } /* Field Access */ -- 2.13.6