Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/3] [gdb] Re-indent regformats/regdat.sh
Date: Tue, 1 Sep 2026 11:21:40 +0200	[thread overview]
Message-ID: <2f7e4de6-483e-4051-992a-092794d4804a@suse.de> (raw)
In-Reply-To: <b767c888-2550-4762-8398-7ac462d81f11@simark.ca>

On 8/31/26 10:09 PM, Simon Marchi wrote:
> On 8/30/26 3:53 PM, Tom de Vries wrote:
>> The script gdb/regformats/regdat.sh has inconsistent indentation: both 2 and 4
>> spaces.
>>
>> Standardize to 4 spaces (as specified by .editorconfig), and document this
>> explicitly using a Local Variables setting, copied from
>> gdb/contrib/expect-read1.sh.
> 
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 
> LGTM, but I wonder why the local variables setting is needed, since we
> have .editorconfig?  For instance, we don't put that in every .c file...
> I am not strongly opposed to it, but it seems redundant and less
> maintainable to repeat the information in each file.
> 

Hi Simon,

thanks for the reviews.

I've pushed this, without the local variables part.

Instead I've submitted a patch to add a setting in .dir-locals.el ( 
https://sourceware.org/pipermail/gdb-patches/2026-September/229895.html ).

Thanks,
- Tom

> Simon


  reply	other threads:[~2026-09-01  9:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 19:53 [PATCH v2 0/3] [gdb] Reformat regformats/regdat.sh Tom de Vries
2026-08-30 19:53 ` [PATCH v2 1/3] [gdb] Re-indent regformats/regdat.sh Tom de Vries
2026-08-31 20:09   ` Simon Marchi
2026-09-01  9:21     ` Tom de Vries [this message]
2026-08-30 19:53 ` [PATCH v2 2/3] [gdb] Use shfmt on regformats/regdat.sh Tom de Vries
2026-08-31 20:13   ` Simon Marchi
2026-09-02 13:21     ` Tom de Vries
2026-08-30 19:53 ` [PATCH v2 3/3] [gdb] Use shfmt --simplify " Tom de Vries
2026-08-31 20:14   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f7e4de6-483e-4051-992a-092794d4804a@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox