Re: [PATCH v2 2/3] [gdb] Use shfmt on regformats/regdat.sh

[Simon Marchi <simark@simark.ca>]

On 8/30/26 3:53 PM, Tom de Vries wrote:
> Run shfmt [1] on gdb/regformats/regdat.sh:
> ...
> $ shfmt \
>     --language-dialect=posix \
>     --indent=4 \
>     --func-next-line \
>     --space-redirects \
>     --write \
>     gdb/regformats/regdat.sh

It would be nice to have a script to easily do this on all our shell
scripts, which we could also run in the CI (like we run black to verify
the Python code formatting).

> ...
> followed by emacs whitespace-cleanup (because shfmt doesn't know about mixed
> tab/spaces indentation).

I guess said script would need to do this too (I wonder if it can be
done with sed, replacing leading groups of 8 spaces with a tab).

> Normalizes things like:
> ...
> if true
> then
> ...
> to:
> ...
> if true; then
> ...
> as suggested by Simon [2].
> 
> Also:
> - makes sure statements are on their own line
> - removes double empty line
> - minor whitespace changes:
>   - do_read ()      -> do_read()
>   - cat <<EOF       -> cat << EOF
> 
> [1] https://github.com/mvdan/sh
> [2] https://sourceware.org/pipermail/gdb-patches/2026-August/229818.html

All the changes in the diff LGTM.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon