From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/3] [gdb] Use shfmt --simplify on regformats/regdat.sh
Date: Mon, 31 Aug 2026 16:14:19 -0400 [thread overview]
Message-ID: <0d3d0d6c-35bf-44bf-b77d-69e2c820f438@simark.ca> (raw)
In-Reply-To: <20260830195315.1497894-4-tdevries@suse.de>
On 8/30/26 3:53 PM, Tom de Vries wrote:
> Use shfmt on gdb/regformats/regdat.sh as in the previous commit, but also use
> --simplify.
> ---
> gdb/regformats/regdat.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/regformats/regdat.sh b/gdb/regformats/regdat.sh
> index 6cac186735e..486fc0e85ea 100755
> --- a/gdb/regformats/regdat.sh
> +++ b/gdb/regformats/regdat.sh
> @@ -178,7 +178,7 @@ elif test "${xmltarget}" = x; then
> if test "${xmlosabi}" != x; then
> echo "<osabi>${xmlosabi}</osabi>\\"
> fi
> - echo "</target>\";"
> + echo '</target>";'
> fi
> else
> echo "static const char *xmltarget_${name} = \"${xmltarget}\";"
LGTM.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2026-08-31 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 19:53 [PATCH v2 0/3] [gdb] Reformat regformats/regdat.sh Tom de Vries
2026-08-30 19:53 ` [PATCH v2 1/3] [gdb] Re-indent regformats/regdat.sh Tom de Vries
2026-08-31 20:09 ` Simon Marchi
2026-09-01 9:21 ` Tom de Vries
2026-08-30 19:53 ` [PATCH v2 2/3] [gdb] Use shfmt on regformats/regdat.sh Tom de Vries
2026-08-31 20:13 ` Simon Marchi
2026-09-02 13:21 ` Tom de Vries
2026-08-30 19:53 ` [PATCH v2 3/3] [gdb] Use shfmt --simplify " Tom de Vries
2026-08-31 20:14 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3d0d6c-35bf-44bf-b77d-69e2c820f438@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox