From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sZYwH0eZlmrlSBoAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 05:22:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QxfwLFKw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KG13pd9O; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HWbgxa66; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wEJtDJa2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 78AE71E166; Tue, 01 Sep 2026 05:22:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 93EA91E09B for ; Tue, 01 Sep 2026 05:22:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C1DB4BA23E9 for ; Tue, 1 Sep 2026 09:22:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C1DB4BA23E9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QxfwLFKw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KG13pd9O; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HWbgxa66; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wEJtDJa2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id EAA834BA2E0D for ; Tue, 1 Sep 2026 09:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAA834BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAA834BA2E0D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788254510; cv=none; b=Irsf+SRI9R73a3KUS3XXR72qI8JyySJ2G1vI4eFyH1VKg0R73tPMvCYkynyOzO5llqHNHw7uqDI8IQO/aeLyLJUT1c8C6Due1IgNjBzZa4kPjIZXxoB+xHY3HzHtuH6VEiudvqUCdbXqDO9nK57wyyQZPM9UsbfopMlNr34XOX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788254510; c=relaxed/simple; bh=pUDo40MNqdySLTkKbO6bLR65rYg7KaJm83+K9znvcWs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=wm5Pd4WZPWCwatJdnPXiBlA5PTSV1kkYphD4UgRGQYjN+fcnGgH2A7ZeBlWLX23OuowgGjL15ARPRU+m3ZeYiR06J2LqIPmmV3su3my9X7k4gMPbqtKRVeqB2vptbtgxjEFCaeGUiUmqqrizSxAKxALHUAJ4xpHN83zbAvseLJ8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QxfwLFKw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KG13pd9O; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HWbgxa66; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wEJtDJa2 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EAA834BA2E0D Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BB8FC22804; Tue, 1 Sep 2026 09:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788254504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCigRi7NmVbitSAzw1MG+fZl8DYMqvUXtUlOsJ9GGzc=; b=QxfwLFKwir+cu6z1gukEUU386bGi82ikcGrwZOxGnLQYwO5aWTvh1J3fCRRgvpHT+0DVu8 hnNKWbN15NfDYwoqvVOVJYAVT8uAUY1+4BNXyuDIzbTLZYmeM/+njWtsR1QSq5L8Kjrcuc 0wm4RCLWKvxeiGeNdQj1K/7e1j4muro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788254504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCigRi7NmVbitSAzw1MG+fZl8DYMqvUXtUlOsJ9GGzc=; b=KG13pd9OxEuh9CbzyJIl4U3ZO/KBab5quLB3imFbRj9gVuvsvLBjCoiTA+112PX9VLyTLW SnfDjw8mltjozXCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HWbgxa66; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wEJtDJa2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788254500; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCigRi7NmVbitSAzw1MG+fZl8DYMqvUXtUlOsJ9GGzc=; b=HWbgxa66OMqGXyzfdk0Fn4FdKxhGutW/h3p8eJeJ5+GRBThNCtuFO2kBSUHgpPV35sGyhX +1UCav+ztd3gwiot7+U9BtC4tHlO6rsv3kNvIokY/Xwl5nPW2CZsU3MyXFb1GrbOPapH8u fOep91rGaeIiA7iee3YBv+/jigonrXk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788254500; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCigRi7NmVbitSAzw1MG+fZl8DYMqvUXtUlOsJ9GGzc=; b=wEJtDJa2C+b51fY7Ht+GUwKdZEOIVhjAoOT/YarsyvTucYIyZwEBbsViXTWfA6zuT0xtqo 5gOIwBp2nt5xH0BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8BA031369E; Tue, 1 Sep 2026 09:21:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5gysICSZlmo3OwAAD6G6ig (envelope-from ); Tue, 01 Sep 2026 09:21:40 +0000 Message-ID: <2f7e4de6-483e-4051-992a-092794d4804a@suse.de> Date: Tue, 1 Sep 2026 11:21:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] [gdb] Re-indent regformats/regdat.sh To: Simon Marchi , gdb-patches@sourceware.org References: <20260830195315.1497894-1-tdevries@suse.de> <20260830195315.1497894-2-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BB8FC22804 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[efficios.com:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/31/26 10:09 PM, Simon Marchi wrote: > On 8/30/26 3:53 PM, Tom de Vries wrote: >> The script gdb/regformats/regdat.sh has inconsistent indentation: both 2 and 4 >> spaces. >> >> Standardize to 4 spaces (as specified by .editorconfig), and document this >> explicitly using a Local Variables setting, copied from >> gdb/contrib/expect-read1.sh. > > Approved-By: Simon Marchi > > LGTM, but I wonder why the local variables setting is needed, since we > have .editorconfig? For instance, we don't put that in every .c file... > I am not strongly opposed to it, but it seems redundant and less > maintainable to repeat the information in each file. > Hi Simon, thanks for the reviews. I've pushed this, without the local variables part. Instead I've submitted a patch to add a setting in .dir-locals.el ( https://sourceware.org/pipermail/gdb-patches/2026-September/229895.html ). Thanks, - Tom > Simon