From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/5] Use std::string in cp-namespace.c
Date: Thu, 22 Sep 2016 19:08:00 -0000 [thread overview]
Message-ID: <2e60c3c8-800c-36c7-c3c1-a53583ac91fd@redhat.com> (raw)
In-Reply-To: <1474566656-15389-3-git-send-email-tom@tromey.com>
On 09/22/2016 06:50 PM, Tom Tromey wrote:
> - name_copy[prefix_len] = '\0';
> + name_copy.erase (prefix_len, name_copy.size ());
Passing name_copy.size () here looks odd, since that parameter is
how many bytes to erase. Just don't pass a second parameter,
which defaults to std::string::npos?
> context = lookup_typename (lang, arch,
> - name_copy,
> + name_copy.c_str (),
> parent, 1);
> }
>
--
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-09-22 19:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 17:51 [RFA 0/5] Some random C++-ification Tom Tromey
2016-09-22 17:51 ` [RFA 2/5] Use std::string in cp-namespace.c Tom Tromey
2016-09-22 19:08 ` Pedro Alves [this message]
2016-09-22 20:56 ` Tom Tromey
2016-09-22 17:51 ` [RFA 4/5] Use std::vector in objfiles.c Tom Tromey
2016-09-22 17:51 ` [RFA 3/5] Use std::string, std::vector in rust-lang.c Tom Tromey
2016-09-22 19:03 ` Pedro Alves
2016-09-22 19:24 ` Tom Tromey
2016-09-22 19:35 ` Pedro Alves
2016-09-22 20:37 ` Pierre Muller
[not found] ` <57e4328a.c3c4620a.59d5b.803fSMTPIN_ADDED_BROKEN@mx.google.com>
2016-09-23 9:44 ` Pedro Alves
2016-09-23 15:56 ` Tom Tromey
2016-09-23 16:15 ` Pedro Alves
2016-09-22 17:51 ` [RFA 1/5] Use std::string in break-catch-sig.c Tom Tromey
2016-09-23 13:17 ` Yao Qi
2016-09-22 19:03 ` [RFA 5/5] Use std::string rather than dyn-string Tom Tromey
2016-09-22 19:10 ` [RFA 0/5] Some random C++-ification Pedro Alves
2016-09-22 19:15 ` Pedro Alves
2016-09-22 23:10 ` Trevor Saunders
2016-09-23 15:47 ` Tom Tromey
2016-09-23 15:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e60c3c8-800c-36c7-c3c1-a53583ac91fd@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox