From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117645 invoked by alias); 22 Sep 2016 19:03:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117586 invoked by uid 89); 22 Sep 2016 19:03:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Sep 2016 19:03:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 186D563716; Thu, 22 Sep 2016 19:03:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8MJ3Cgh000597; Thu, 22 Sep 2016 15:03:13 -0400 Subject: Re: [RFA 2/5] Use std::string in cp-namespace.c To: Tom Tromey , gdb-patches@sourceware.org References: <1474566656-15389-1-git-send-email-tom@tromey.com> <1474566656-15389-3-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <2e60c3c8-800c-36c7-c3c1-a53583ac91fd@redhat.com> Date: Thu, 22 Sep 2016 19:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474566656-15389-3-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00293.txt.bz2 On 09/22/2016 06:50 PM, Tom Tromey wrote: > - name_copy[prefix_len] = '\0'; > + name_copy.erase (prefix_len, name_copy.size ()); Passing name_copy.size () here looks odd, since that parameter is how many bytes to erase. Just don't pass a second parameter, which defaults to std::string::npos? > context = lookup_typename (lang, arch, > - name_copy, > + name_copy.c_str (), > parent, 1); > } > -- Thanks, Pedro Alves