From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 0/5] Some random C++-ification
Date: Thu, 22 Sep 2016 23:10:00 -0000 [thread overview]
Message-ID: <20160922210310.teeeute7dwt7rnpy@ball> (raw)
In-Reply-To: <1ee37f8c-0c1a-7368-4cea-96bbbf43a2af@redhat.com>
On Thu, Sep 22, 2016 at 08:08:20PM +0100, Pedro Alves wrote:
> On 09/22/2016 06:50 PM, Tom Tromey wrote:
> > I was feeling inspired by Pedro's Cauldron slides, so I found a few
>
> Awesome! :-)
>
> > random spots that could be converted from cleanups to self-managing
> > data structures from libstdc++ -- in these cases, std::string and
> > std::vector.
> >
> > I saw a note in one of the C++ conversion documents about perhaps not
> > using std::vector, since GCC did not. However, I think often GCC's
> > uses are unusual, and I don't think there is any reason to avoid
> > std::vector in (most of) gdb.
>
> Agreed.
yeah, gcc has the "reason" of needing vec to work with gc. gdb might
want the perf advantage in auto_vec of using stack storage for short
arrays, but that's the only reason I can see to not use std::vector
outside of heap data structures. In the heap I think the auto_vec
layout is better than std::vector, but again just a perf question.
Trev
next prev parent reply other threads:[~2016-09-22 20:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 17:51 Tom Tromey
2016-09-22 17:51 ` [RFA 4/5] Use std::vector in objfiles.c Tom Tromey
2016-09-22 17:51 ` [RFA 2/5] Use std::string in cp-namespace.c Tom Tromey
2016-09-22 19:08 ` Pedro Alves
2016-09-22 20:56 ` Tom Tromey
2016-09-22 17:51 ` [RFA 1/5] Use std::string in break-catch-sig.c Tom Tromey
2016-09-23 13:17 ` Yao Qi
2016-09-22 17:51 ` [RFA 3/5] Use std::string, std::vector in rust-lang.c Tom Tromey
2016-09-22 19:03 ` Pedro Alves
2016-09-22 19:24 ` Tom Tromey
2016-09-22 19:35 ` Pedro Alves
2016-09-22 20:37 ` Pierre Muller
[not found] ` <57e4328a.c3c4620a.59d5b.803fSMTPIN_ADDED_BROKEN@mx.google.com>
2016-09-23 9:44 ` Pedro Alves
2016-09-23 15:56 ` Tom Tromey
2016-09-23 16:15 ` Pedro Alves
2016-09-22 19:03 ` [RFA 5/5] Use std::string rather than dyn-string Tom Tromey
2016-09-22 19:10 ` [RFA 0/5] Some random C++-ification Pedro Alves
2016-09-22 19:15 ` Pedro Alves
2016-09-22 23:10 ` Trevor Saunders [this message]
2016-09-23 15:47 ` Tom Tromey
2016-09-23 15:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922210310.teeeute7dwt7rnpy@ball \
--to=tbsaunde@tbsaunde.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox